Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes /internal/security/me serverless test #195846

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Fixes /internal/security/me serverless test #195846

merged 1 commit into from
Oct 11, 2024

Conversation

jeramysoucy
Copy link
Contributor

Summary

Replaces the name check with role check. The full name of the user is different between local and MKI environments.

@jeramysoucy jeramysoucy added Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v9.0.0 labels Oct 11, 2024
@jeramysoucy jeramysoucy marked this pull request as ready for review October 11, 2024 06:09
@jeramysoucy jeramysoucy requested a review from a team as a code owner October 11, 2024 06:09
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

@jeramysoucy jeramysoucy self-assigned this Oct 11, 2024
pheyos
pheyos approved these changes Oct 11, 2024
View reviewed changes
Copy link
Member

@pheyos pheyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elena-shostak elena-shostak enabled auto-merge (squash) October 11, 2024 07:48
@elena-shostak elena-shostak merged commit 3079ef2 into elastic:main Oct 11, 2024
30 checks passed
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

cc @jeramysoucy

@wayneseymour wayneseymour mentioned this pull request Oct 11, 2024
Closed
@kc13greiner kc13greiner mentioned this pull request Oct 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elena-shostak elena-shostak elena-shostak approved these changes

@pheyos pheyos pheyos approved these changes

Assignees

@jeramysoucy jeramysoucy

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jeramysoucy @elasticmachine @pheyos @elena-shostak