[SecuritySolution][Threat Intelligence] - re-enable Cypress test skipped because of removal of bsearch #195826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilippeOberti
added
release_note:skip
|
Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations) |
christineweng
approved these changes
Oct 11, 2024
...st/security_solution_cypress/cypress/e2e/investigations/threat_intelligence/indicators.cy.ts
Outdated
Show resolved
Hide resolved
…ped because of removal of bsearch
PhilippeOberti
force-pushed
the
re-enable-ti-test
branch
from
bd8f5d0 to
abae1f1
Compare
💚 Build Succeeded
Metrics [docs]
History
|
PhilippeOberti
added a commit
to PhilippeOberti/kibana
that referenced
this pull request
Oct 25, 2024
…ped because of removal of bsearch (elastic#195826) (cherry picked from commit edd8f08)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A Threat Intelligence Cypress test was skipped (see ticket here) because this PR that disables
bfetchby default was merged shortly before. I'm not sure why we merged a PR that breaks Cypress tests, and skipped these tests instead of reverting the PR...This PR fixes the issue by intercepting the correct
/internal/search/threatIntelligenceSearchStrategycall and re-enables the test suite.