[Search][Onboarding] Enable search indices & gate with a feature flag #195802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TattdCodeMonkey
added
release_note:skip
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#7123[✅] x-pack/test_serverless/functional/test_suites/search/config.feature_flags.ts: 25/25 tests passed. |
joemcelroy
approved these changes
Oct 10, 2024
|
@elasticmachine merge upstream |
jloleysens
added
the
ci:project-deploy-elasticsearch
jloleysens
approved these changes
Oct 11, 2024
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Page load bundle
History
|
sphilipse
approved these changes
Oct 11, 2024
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11296621299 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 11, 2024
…elastic#195802) ## Summary This PR enables the `search_indices` plugin in serverless search. But then gates it with a UI settings feature flag until we are ready to ship the new onboarding experience to all users. ### Testing Locally you can add this to your `kibana.dev.yml` to enable the FF: ``` uiSettings.overrides.searchIndices:globalEmptyStateEnabled: true ``` Or you can enable the ui setting via Dev Tools and refresh the browser: ``` POST kbn:/internal/kibana/settings/searchIndices:globalEmptyStateEnabled {"value": true} ``` ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Jean-Louis Leysens <[email protected]> (cherry picked from commit 8577d13)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 11, 2024
…ature flag (#195802) (#195972) # Backport This will backport the following commits from `main` to `8.x`: - [[Search][Onboarding] Enable search indices & gate with a feature flag (#195802)](#195802) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Rodney Norris","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-11T17:21:47Z","message":"[Search][Onboarding] Enable search indices & gate with a feature flag (#195802)\n\n## Summary\r\n\r\nThis PR enables the `search_indices` plugin in serverless search. But\r\nthen gates it with a UI settings feature flag until we are ready to ship\r\nthe new onboarding experience to all users.\r\n\r\n### Testing\r\nLocally you can add this to your `kibana.dev.yml` to enable the FF:\r\n```\r\nuiSettings.overrides.searchIndices:globalEmptyStateEnabled: true\r\n```\r\n\r\nOr you can enable the ui setting via Dev Tools and refresh the browser:\r\n\r\n```\r\nPOST kbn:/internal/kibana/settings/searchIndices:globalEmptyStateEnabled\r\n{\"value\": true}\r\n```\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>\r\nCo-authored-by: Jean-Louis Leysens <[email protected]>","sha":"8577d1357e2c59f66e397a480ec39b2c405787db","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Search","backport:prev-minor","ci:project-deploy-elasticsearch"],"title":"[Search][Onboarding] Enable search indices & gate with a feature flag","number":195802,"url":"https://github.com/elastic/kibana/pull/195802","mergeCommit":{"message":"[Search][Onboarding] Enable search indices & gate with a feature flag (#195802)\n\n## Summary\r\n\r\nThis PR enables the `search_indices` plugin in serverless search. But\r\nthen gates it with a UI settings feature flag until we are ready to ship\r\nthe new onboarding experience to all users.\r\n\r\n### Testing\r\nLocally you can add this to your `kibana.dev.yml` to enable the FF:\r\n```\r\nuiSettings.overrides.searchIndices:globalEmptyStateEnabled: true\r\n```\r\n\r\nOr you can enable the ui setting via Dev Tools and refresh the browser:\r\n\r\n```\r\nPOST kbn:/internal/kibana/settings/searchIndices:globalEmptyStateEnabled\r\n{\"value\": true}\r\n```\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>\r\nCo-authored-by: Jean-Louis Leysens <[email protected]>","sha":"8577d1357e2c59f66e397a480ec39b2c405787db"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195802","number":195802,"mergeCommit":{"message":"[Search][Onboarding] Enable search indices & gate with a feature flag (#195802)\n\n## Summary\r\n\r\nThis PR enables the `search_indices` plugin in serverless search. But\r\nthen gates it with a UI settings feature flag until we are ready to ship\r\nthe new onboarding experience to all users.\r\n\r\n### Testing\r\nLocally you can add this to your `kibana.dev.yml` to enable the FF:\r\n```\r\nuiSettings.overrides.searchIndices:globalEmptyStateEnabled: true\r\n```\r\n\r\nOr you can enable the ui setting via Dev Tools and refresh the browser:\r\n\r\n```\r\nPOST kbn:/internal/kibana/settings/searchIndices:globalEmptyStateEnabled\r\n{\"value\": true}\r\n```\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>\r\nCo-authored-by: Jean-Louis Leysens <[email protected]>","sha":"8577d1357e2c59f66e397a480ec39b2c405787db"}}]}] BACKPORT--> Co-authored-by: Rodney Norris <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR enables the
search_indicesplugin in serverless search. But then gates it with a UI settings feature flag until we are ready to ship the new onboarding experience to all users.Testing
Locally you can add this to your
kibana.dev.ymlto enable the FF:Or you can enable the ui setting via Dev Tools and refresh the browser:
Checklist