[ResponseOps][Alerts] Don't show empty state in grouping component while first loading #195777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umbopepato
added
release_note:skip
|
Pinging @elastic/response-ops (Team:ResponseOps) |
umbopepato
requested review from
logeekal,
maryam-saeidi,
JiaweiWu and
ersin-erdal
cnasikas
reviewed
Oct 11, 2024
There was a problem hiding this comment.
Could you please add a unit test for the new behavior?
There was a problem hiding this comment.
I took the occasion and also updated the whole test file to screen._ queries 🙂
cnasikas
approved these changes
Oct 11, 2024
…-empty-state-while-loading
adcoelho
approved these changes
Oct 14, 2024
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
|
Starting backport for target branches: 8.15, 8.x https://github.com/elastic/kibana/actions/runs/11326038498 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 14, 2024
…ile first loading (elastic#195777) ## Summary Makes the loading state and empty state mutually exclusive in the grouping component to avoid showing the empty state when first loading the groups data. ## To verify 1. Create one or more O11y rules that fire alerts 2. Open the O11y > Alerts page 3. Toggle on grouping 4. Reload the page (possibly after activating network throttling) 5. Verify that while the loading indicator is shown, the empty state is not and viceversa ## References Fixes elastic#190954 (cherry picked from commit 45a9cf0)
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 14, 2024
…omponent while first loading (#195777) (#196106) # Backport This will backport the following commits from `main` to `8.x`: - [[ResponseOps][Alerts] Don't show empty state in grouping component while first loading (#195777)](#195777) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Umberto Pepato","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-14T10:50:55Z","message":"[ResponseOps][Alerts] Don't show empty state in grouping component while first loading (#195777)\n\n## Summary\r\n\r\nMakes the loading state and empty state mutually exclusive in the\r\ngrouping component to avoid showing the empty state when first loading\r\nthe groups data.\r\n\r\n## To verify\r\n\r\n1. Create one or more O11y rules that fire alerts\r\n2. Open the O11y > Alerts page\r\n3. Toggle on grouping\r\n4. Reload the page (possibly after activating network throttling)\r\n5. Verify that while the loading indicator is shown, the empty state is\r\nnot and viceversa\r\n\r\n## References\r\n\r\nFixes #190954","sha":"45a9cf0e343e6c4045834968fa27f6f468cdf3e3","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","v9.0.0","backport:prev-major"],"title":"[ResponseOps][Alerts] Don't show empty state in grouping component while first loading","number":195777,"url":"https://github.com/elastic/kibana/pull/195777","mergeCommit":{"message":"[ResponseOps][Alerts] Don't show empty state in grouping component while first loading (#195777)\n\n## Summary\r\n\r\nMakes the loading state and empty state mutually exclusive in the\r\ngrouping component to avoid showing the empty state when first loading\r\nthe groups data.\r\n\r\n## To verify\r\n\r\n1. Create one or more O11y rules that fire alerts\r\n2. Open the O11y > Alerts page\r\n3. Toggle on grouping\r\n4. Reload the page (possibly after activating network throttling)\r\n5. Verify that while the loading indicator is shown, the empty state is\r\nnot and viceversa\r\n\r\n## References\r\n\r\nFixes #190954","sha":"45a9cf0e343e6c4045834968fa27f6f468cdf3e3"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195777","number":195777,"mergeCommit":{"message":"[ResponseOps][Alerts] Don't show empty state in grouping component while first loading (#195777)\n\n## Summary\r\n\r\nMakes the loading state and empty state mutually exclusive in the\r\ngrouping component to avoid showing the empty state when first loading\r\nthe groups data.\r\n\r\n## To verify\r\n\r\n1. Create one or more O11y rules that fire alerts\r\n2. Open the O11y > Alerts page\r\n3. Toggle on grouping\r\n4. Reload the page (possibly after activating network throttling)\r\n5. Verify that while the loading indicator is shown, the empty state is\r\nnot and viceversa\r\n\r\n## References\r\n\r\nFixes #190954","sha":"45a9cf0e343e6c4045834968fa27f6f468cdf3e3"}}]}] BACKPORT--> Co-authored-by: Umberto Pepato <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Makes the loading state and empty state mutually exclusive in the grouping component to avoid showing the empty state when first loading the groups data.
To verify
References
Fixes #190954