Agentless api fix delete path #195762
Merged
Agentless api fix delete path #195762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amirbenun
added
Team:Cloud Security
|
Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security) |
juliaElastic
approved these changes
Oct 10, 2024
botelastic
bot
added
the
Team:Fleet
|
Pinging @elastic/fleet (Team:Fleet) |
Omolola-Akinleye
approved these changes
Oct 10, 2024
|
Starting backport for target branches: 8.15, 8.x https://github.com/elastic/kibana/actions/runs/11283117636 |
💚 Build Succeeded
Metrics [docs]
History
|
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 10, 2024
## Summary Agentless API delete path should have the `ess` or `serverless` mark based on the environment. This PR build the request URL based on that. (cherry picked from commit 872d9da)
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 11, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [Agentless api fix delete path (#195762)](#195762) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Amir Ben Nun","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-10T22:44:25Z","message":"Agentless api fix delete path (#195762)\n\n## Summary\r\nAgentless API delete path should have the `ess` or `serverless` mark\r\nbased on the environment.\r\nThis PR build the request URL based on that.","sha":"872d9da30e74f64dd33e25c6fed2d55e6aa4af47","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Fleet","v9.0.0","Team:Cloud Security","backport:prev-major","v8.16.0"],"title":"Agentless api fix delete path","number":195762,"url":"https://github.com/elastic/kibana/pull/195762","mergeCommit":{"message":"Agentless api fix delete path (#195762)\n\n## Summary\r\nAgentless API delete path should have the `ess` or `serverless` mark\r\nbased on the environment.\r\nThis PR build the request URL based on that.","sha":"872d9da30e74f64dd33e25c6fed2d55e6aa4af47"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195762","number":195762,"mergeCommit":{"message":"Agentless api fix delete path (#195762)\n\n## Summary\r\nAgentless API delete path should have the `ess` or `serverless` mark\r\nbased on the environment.\r\nThis PR build the request URL based on that.","sha":"872d9da30e74f64dd33e25c6fed2d55e6aa4af47"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Amir Ben Nun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Agentless API delete path should have the
essorserverlessmark based on the environment.This PR build the request URL based on that.
Checklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers