[Stateful sidenav] Feedback button #195751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebelga
added
Team:SharedUX
|
Pinging @elastic/appex-sharedux (Team:SharedUX) |
Dosant
reviewed
Oct 10, 2024
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11294195504 |
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Page load bundle
Unknown metric groupsAPI count
History
cc @sebelga |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 11, 2024
(cherry picked from commit c1c70c7)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 11, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [[Stateful sidenav] Feedback button (#195751)](#195751) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Sébastien Loix","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-11T14:29:39Z","message":"[Stateful sidenav] Feedback button (#195751)","sha":"c1c70c73aa02931f39045fdf2bc7938aea53c58d","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:SharedUX","backport:prev-minor","Feature:Chrome"],"title":"[Stateful sidenav] Feedback button","number":195751,"url":"https://github.com/elastic/kibana/pull/195751","mergeCommit":{"message":"[Stateful sidenav] Feedback button (#195751)","sha":"c1c70c73aa02931f39045fdf2bc7938aea53c58d"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195751","number":195751,"mergeCommit":{"message":"[Stateful sidenav] Feedback button (#195751)","sha":"c1c70c73aa02931f39045fdf2bc7938aea53c58d"}}]}] BACKPORT--> Co-authored-by: Sébastien Loix <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I've added a feedback btn in the new solution side nav for non trial users.
As long as a deployment is in the trial dates, the button does not show. When the trial ends, if the deployment is still running, then the button appears.
The button can be dismissed, but the state is in
sessionStorage. That means that it reappears when Kibana is opened in a new browser window or tab.How to test
kibana.dev.ymlkibana.dev.ymlScreenshots
Fixes https://github.com/elastic/kibana-team/issues/1135