Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github-actions: grant write permissions to report to the issues #195706

Merged
merged 2 commits into from
Oct 10, 2024
Merged

Conversation

v1v
Copy link
Member

@v1v v1v commented Oct 10, 2024

Summary

For some reason it reports an error and link to https://docs.github.com/en/rest/issues/comments?apiVersion=2022-11-28#create-an-issue-comment

while pull-requests: write is already set :/

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@v1v v1v added release_note:skip Skip the PR/issue when compiling release notes backport:prev-major Backport to (8.x, 8.17, 8.16, 8.15) the previous major branch and other branches in development labels Oct 10, 2024
@v1v v1v requested a review from a team October 10, 2024 07:37
@v1v v1v self-assigned this Oct 10, 2024
@v1v v1v requested a review from a team as a code owner October 10, 2024 07:37
@v1v v1v enabled auto-merge (squash) October 10, 2024 07:44
@v1v v1v merged commit 44a42a7 into main Oct 10, 2024
9 checks passed
@v1v v1v deleted the v1v-patch-1 branch October 10, 2024 10:35
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.15, 8.x

https://github.com/elastic/kibana/actions/runs/11272323676

@v1v v1v added the ci:project-deploy-observability Create an Observability project label Oct 10, 2024
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
8.15 Backport failed because of merge conflicts
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 195706

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 10, 2024
…#195706) (#195738)

# Backport

This will backport the following commits from `main` to `8.x`:
- [github-actions: grant write permissions to report to the issues
(#195706)](#195706)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Victor
Martinez","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-10T10:35:03Z","message":"github-actions:
grant write permissions to report to the issues
(#195706)","sha":"44a42a7a2a22e0ee7ed6d1f8deb1f5f12ca2b155","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-major"],"title":"github-actions:
grant write permissions to report to the
issues","number":195706,"url":"https://github.com/elastic/kibana/pull/195706","mergeCommit":{"message":"github-actions:
grant write permissions to report to the issues
(#195706)","sha":"44a42a7a2a22e0ee7ed6d1f8deb1f5f12ca2b155"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195706","number":195706,"mergeCommit":{"message":"github-actions:
grant write permissions to report to the issues
(#195706)","sha":"44a42a7a2a22e0ee7ed6d1f8deb1f5f12ca2b155"}}]}]
BACKPORT-->

Co-authored-by: Victor Martinez <[email protected]>
@v1v
Copy link
Member Author

v1v commented Oct 11, 2024

💚 All backports created successfully

Status Branch Result
8.15

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

v1v added a commit to v1v/kibana that referenced this pull request Oct 11, 2024
v1v added a commit that referenced this pull request Oct 11, 2024
#195706) (#195923)

# Backport

This will backport the following commits from `main` to `8.15`:
- [github-actions: grant write permissions to report to the issues
(#195706)](#195706)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Victor
Martinez","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-10T10:35:03Z","message":"github-actions:
grant write permissions to report to the issues
(#195706)","sha":"44a42a7a2a22e0ee7ed6d1f8deb1f5f12ca2b155","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-major","ci:project-deploy-observability","v8.16.0"],"number":195706,"url":"https://github.com/elastic/kibana/pull/195706","mergeCommit":{"message":"github-actions:
grant write permissions to report to the issues
(#195706)","sha":"44a42a7a2a22e0ee7ed6d1f8deb1f5f12ca2b155"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195706","number":195706,"mergeCommit":{"message":"github-actions:
grant write permissions to report to the issues
(#195706)","sha":"44a42a7a2a22e0ee7ed6d1f8deb1f5f12ca2b155"}},{"branch":"8.x","label":"v8.16.0","labelRegex":"^v8.16.0$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/195738","number":195738,"state":"MERGED","mergeCommit":{"sha":"950e0738909399ab30830bda6b9b65e8747c5115","message":"[8.x]
github-actions: grant write permissions to report to the issues
(#195706) (#195738)\n\n# Backport\n\nThis will backport the following
commits from `main` to `8.x`:\n- [github-actions: grant write
permissions to report to the
issues\n(#195706)](https://github.com/elastic/kibana/pull/195706)\n\n<!---
Backport version: 9.4.3 -->\n\n### Questions ?\nPlease refer to the
[Backport
tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT
[{\"author\":{\"name\":\"Victor\nMartinez\",\"email\":\"[email protected]\"},\"sourceCommit\":{\"committedDate\":\"2024-10-10T10:35:03Z\",\"message\":\"github-actions:\ngrant
write permissions to report to the
issues\n(#195706)\",\"sha\":\"44a42a7a2a22e0ee7ed6d1f8deb1f5f12ca2b155\",\"branchLabelMapping\":{\"^v9.0.0$\":\"main\",\"^v8.16.0$\":\"8.x\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"release_note:skip\",\"v9.0.0\",\"backport:prev-major\"],\"title\":\"github-actions:\ngrant
write permissions to report to
the\nissues\",\"number\":195706,\"url\":\"https://github.com/elastic/kibana/pull/195706\",\"mergeCommit\":{\"message\":\"github-actions:\ngrant
write permissions to report to the
issues\n(#195706)\",\"sha\":\"44a42a7a2a22e0ee7ed6d1f8deb1f5f12ca2b155\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[],\"targetPullRequestStates\":[{\"branch\":\"main\",\"label\":\"v9.0.0\",\"branchLabelMappingKey\":\"^v9.0.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/195706\",\"number\":195706,\"mergeCommit\":{\"message\":\"github-actions:\ngrant
write permissions to report to the
issues\n(#195706)\",\"sha\":\"44a42a7a2a22e0ee7ed6d1f8deb1f5f12ca2b155\"}}]}]\nBACKPORT-->\n\nCo-authored-by:
Victor Martinez <[email protected]>"}}]}] BACKPORT-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-major Backport to (8.x, 8.17, 8.16, 8.15) the previous major branch and other branches in development ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes v8.15.3 v8.16.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants