-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dashboard] do not async import dashboard actions on plugin load #195616
Conversation
/ci |
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is something we've been meaning to do for awhile, so changes are straight forward. Thanks for tackling this - LGTM 👍
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11259922046 |
…stic#195616) Part of elastic#194171 Notice in the screen shot below, how opening Kibana home page loads async dashboard chunks. <img width="500" alt="Screenshot 2024-10-09 at 8 38 24 AM" src="https://github.com/user-attachments/assets/2cfdb512-03e4-4634-bb0c-a8d163f98540"> This PR replaces async import with a sync import. The page load bundle size increases but this is no different than the current behavior, just the import is now properly accounted for in page load stats. The next step is to resolve elastic#191642 and reduce the page load impact of registering uiActions (but this is out of scope for this PR). (cherry picked from commit 7448376)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
#195616) (#195655) # Backport This will backport the following commits from `main` to `8.x`: - [[dashboard] do not async import dashboard actions on plugin load (#195616)](#195616) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Nathan Reese","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-09T17:21:15Z","message":"[dashboard] do not async import dashboard actions on plugin load (#195616)\n\nPart of https://github.com/elastic/kibana/issues/194171\r\n\r\nNotice in the screen shot below, how opening Kibana home page loads\r\nasync dashboard chunks.\r\n<img width=\"500\" alt=\"Screenshot 2024-10-09 at 8 38 24 AM\"\r\nsrc=\"https://github.com/user-attachments/assets/2cfdb512-03e4-4634-bb0c-a8d163f98540\">\r\n\r\nThis PR replaces async import with a sync import. The page load bundle\r\nsize increases but this is no different than the current behavior, just\r\nthe import is now properly accounted for in page load stats. The next\r\nstep is to resolve #191642 and\r\nreduce the page load impact of registering uiActions (but this is out of\r\nscope for this PR).","sha":"7448376119aa1aad0888eb68449c1b15fd0852ac","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Presentation","release_note:skip","v9.0.0","v8.16.0","backport:version"],"title":"[dashboard] do not async import dashboard actions on plugin load","number":195616,"url":"https://github.com/elastic/kibana/pull/195616","mergeCommit":{"message":"[dashboard] do not async import dashboard actions on plugin load (#195616)\n\nPart of https://github.com/elastic/kibana/issues/194171\r\n\r\nNotice in the screen shot below, how opening Kibana home page loads\r\nasync dashboard chunks.\r\n<img width=\"500\" alt=\"Screenshot 2024-10-09 at 8 38 24 AM\"\r\nsrc=\"https://github.com/user-attachments/assets/2cfdb512-03e4-4634-bb0c-a8d163f98540\">\r\n\r\nThis PR replaces async import with a sync import. The page load bundle\r\nsize increases but this is no different than the current behavior, just\r\nthe import is now properly accounted for in page load stats. The next\r\nstep is to resolve #191642 and\r\nreduce the page load impact of registering uiActions (but this is out of\r\nscope for this PR).","sha":"7448376119aa1aad0888eb68449c1b15fd0852ac"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195616","number":195616,"mergeCommit":{"message":"[dashboard] do not async import dashboard actions on plugin load (#195616)\n\nPart of https://github.com/elastic/kibana/issues/194171\r\n\r\nNotice in the screen shot below, how opening Kibana home page loads\r\nasync dashboard chunks.\r\n<img width=\"500\" alt=\"Screenshot 2024-10-09 at 8 38 24 AM\"\r\nsrc=\"https://github.com/user-attachments/assets/2cfdb512-03e4-4634-bb0c-a8d163f98540\">\r\n\r\nThis PR replaces async import with a sync import. The page load bundle\r\nsize increases but this is no different than the current behavior, just\r\nthe import is now properly accounted for in page load stats. The next\r\nstep is to resolve #191642 and\r\nreduce the page load impact of registering uiActions (but this is out of\r\nscope for this PR).","sha":"7448376119aa1aad0888eb68449c1b15fd0852ac"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Nathan Reese <[email protected]>
Part of #194171
Notice in the screen shot below, how opening Kibana home page loads async dashboard chunks.
This PR replaces async import with a sync import. The page load bundle size increases but this is no different than the current behavior, just the import is now properly accounted for in page load stats. The next step is to resolve #191642 and reduce the page load impact of registering uiActions (but this is out of scope for this PR).