Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution][Detection Engine] removes feature flag for logged requests for preview #195569

Merged
merged 5 commits into from
Oct 10, 2024
Merged

[Security Solution][Detection Engine] removes feature flag for logged requests for preview #195569

merged 5 commits into from
Oct 10, 2024

Conversation

vitaliidm
Copy link
Contributor

@vitaliidm vitaliidm commented Oct 9, 2024 •
edited by kibanamachine
Loading

Summary

  • removes feature flag for logged requests for preview

@vitaliidm vitaliidm changed the title [Security Solution][Detection Engine] removes feature flag for enable… [Security Solution][Detection Engine] removes feature flag for logged requests for preview Oct 9, 2024
@vitaliidm vitaliidm self-assigned this Oct 9, 2024
@vitaliidm vitaliidm marked this pull request as ready for review October 9, 2024 10:48
@vitaliidm vitaliidm requested review from a team as code owners October 9, 2024 10:48
@vitaliidm vitaliidm requested a review from rylnd October 9, 2024 10:49
@vitaliidm vitaliidm added release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Team:Detection Engine Security Solution Detection Engine Area labels Oct 9, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detection-engine (Team:Detection Engine)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 20.6MB 20.6MB -44.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
securitySolution 88.8KB 88.7KB -26.0B

History

cc @vitaliidm

@vgomez-el
Copy link

LGTM!

@MadameSheema
Copy link
Member

@vitaliidm please check if any of the new enabled tests on MKI is a good candidate to be executed as part of the Kibana QA quality gate. Thanks!

rylnd
rylnd approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@rylnd rylnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vitaliidm vitaliidm merged commit 84d6899 into elastic:main Oct 10, 2024
44 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11281397712

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 10, 2024
@vitaliidm
[Security Solution][Detection Engine] removes feature flag for logged…
5734219 
… requests for preview (elastic#195569)

## Summary

- removes feature flag for logged requests for preview

(cherry picked from commit 84d6899)
@kibanamachine kibanamachine mentioned this pull request Oct 10, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 10, 2024
@kibanamachine @vitaliidm
[8.x] [Security Solution][Detection Engine] removes feature flag for …
19509fd 
…logged requests for preview (#195569) (#195821)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Security Solution][Detection Engine] removes feature flag for logged
requests for preview
(#195569)](#195569)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Vitalii
Dmyterko","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-10T20:20:50Z","message":"[Security
Solution][Detection Engine] removes feature flag for logged requests for
preview (#195569)\n\n## Summary\r\n \r\n- removes feature flag for
logged requests for
preview","sha":"84d6899a4f2f97e0d015e733cc20064b43636154","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:
SecuritySolution","backport:prev-minor","Team:Detection
Engine"],"title":"[Security Solution][Detection Engine] removes feature
flag for logged requests for
preview","number":195569,"url":"https://github.com/elastic/kibana/pull/195569","mergeCommit":{"message":"[Security
Solution][Detection Engine] removes feature flag for logged requests for
preview (#195569)\n\n## Summary\r\n \r\n- removes feature flag for
logged requests for
preview","sha":"84d6899a4f2f97e0d015e733cc20064b43636154"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195569","number":195569,"mergeCommit":{"message":"[Security
Solution][Detection Engine] removes feature flag for logged requests for
preview (#195569)\n\n## Summary\r\n \r\n- removes feature flag for
logged requests for
preview","sha":"84d6899a4f2f97e0d015e733cc20064b43636154"}}]}]
BACKPORT-->

Co-authored-by: Vitalii Dmyterko <[email protected]>
@nastasha-solomon nastasha-solomon mentioned this pull request Oct 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vgomez-el vgomez-el vgomez-el approved these changes

@rylnd rylnd rylnd approved these changes

Assignees

@vitaliidm vitaliidm

Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:Detection Engine Security Solution Detection Engine Area Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.16.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vitaliidm @elasticmachine @vgomez-el @MadameSheema @kibanamachine @rylnd