Update configuration on changes in category/advanced configurations in configView #195567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artem-shelkovnikov
changed the title
artem-shelkovnikov
added
release_note:fix
backport:version
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
artem-shelkovnikov
deleted the
artem-shelkovnikov/fix-connector-configuration-dependencies
branch
artem-shelkovnikov
added
release_note:skip
|
Starting backport for target branches: 8.15, 8.x https://github.com/elastic/kibana/actions/runs/11269509648 |
artem-shelkovnikov
added
release_note:fix
and removed
release_note:skip
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 10, 2024
…n configView (elastic#195567) ## Closes elastic/search-team#6557 ## Summary Fixes a known bug for Network Drive connector (as this feature is only used in it). The problem happens when there are Rich Configurable Fields that are marked as "advanced" and depend on certain fields - in some cases this field will not be shown until the page is fully reloaded. Criteria that makes the bug happen: 1. Have some RCFs that are marked as "advanced": https://github.com/elastic/connectors/blob/main/connectors/sources/network_drive.py#L405-L414. (`"ui_restrictions": ["advanced"]`) 2. Make it so that this RCF depends on another field, and by default is hidden - for example this field depends on a field "OS" that has "Windows" and "Linux" as available options and Windows is default, but this RCF depends on it being "Linux" 3. Try satisfying the dependency and see if the RCF is displayed - it won't be, unless you save the form and reload it The problem happens because for changes in "advanced" section the configuration is not updated, so the view that's rendered still thinks that the dependency is not satisfied and the field should not be rendered Before: https://github.com/user-attachments/assets/51f9f8b0-a57a-4d96-a183-6dbbd36a919e After: https://github.com/user-attachments/assets/be32f434-0810-4345-bc4e-dc82f617705c ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) (cherry picked from commit 72c76f9)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 10, 2024
…n configView (elastic#195567) ## Closes elastic/search-team#6557 ## Summary Fixes a known bug for Network Drive connector (as this feature is only used in it). The problem happens when there are Rich Configurable Fields that are marked as "advanced" and depend on certain fields - in some cases this field will not be shown until the page is fully reloaded. Criteria that makes the bug happen: 1. Have some RCFs that are marked as "advanced": https://github.com/elastic/connectors/blob/main/connectors/sources/network_drive.py#L405-L414. (`"ui_restrictions": ["advanced"]`) 2. Make it so that this RCF depends on another field, and by default is hidden - for example this field depends on a field "OS" that has "Windows" and "Linux" as available options and Windows is default, but this RCF depends on it being "Linux" 3. Try satisfying the dependency and see if the RCF is displayed - it won't be, unless you save the form and reload it The problem happens because for changes in "advanced" section the configuration is not updated, so the view that's rendered still thinks that the dependency is not satisfied and the field should not be rendered Before: https://github.com/user-attachments/assets/51f9f8b0-a57a-4d96-a183-6dbbd36a919e After: https://github.com/user-attachments/assets/be32f434-0810-4345-bc4e-dc82f617705c ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) (cherry picked from commit 72c76f9)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 10, 2024
…ions in configView (#195567) (#195708) # Backport This will backport the following commits from `main` to `8.x`: - [Update configuration on changes in category/advanced configurations in configView (#195567)](#195567) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Artem Shelkovnikov","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-10T07:34:17Z","message":"Update configuration on changes in category/advanced configurations in configView (#195567)\n\n## Closes https://github.com/elastic/search-team/issues/6557\r\n\r\n## Summary\r\n\r\nFixes a known bug for Network Drive connector (as this feature is only\r\nused in it). The problem happens when there are Rich Configurable Fields\r\nthat are marked as \"advanced\" and depend on certain fields - in some\r\ncases this field will not be shown until the page is fully reloaded.\r\n\r\nCriteria that makes the bug happen:\r\n\r\n1. Have some RCFs that are marked as \"advanced\":\r\nhttps://github.com/elastic/connectors/blob/main/connectors/sources/network_drive.py#L405-L414.\r\n(`\"ui_restrictions\": [\"advanced\"]`)\r\n2. Make it so that this RCF depends on another field, and by default is\r\nhidden - for example this field depends on a field \"OS\" that has\r\n\"Windows\" and \"Linux\" as available options and Windows is default, but\r\nthis RCF depends on it being \"Linux\"\r\n3. Try satisfying the dependency and see if the RCF is displayed - it\r\nwon't be, unless you save the form and reload it\r\n\r\nThe problem happens because for changes in \"advanced\" section the\r\nconfiguration is not updated, so the view that's rendered still thinks\r\nthat the dependency is not satisfied and the field should not be\r\nrendered\r\n\r\nBefore:\r\n\r\n\r\nhttps://github.com/user-attachments/assets/51f9f8b0-a57a-4d96-a183-6dbbd36a919e\r\n\r\nAfter:\r\n\r\n\r\nhttps://github.com/user-attachments/assets/be32f434-0810-4345-bc4e-dc82f617705c\r\n\r\n\r\n### Checklist\r\n\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"72c76f9ac9c43365bcfb70903c9d848012260291","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","v8.16.0","backport:version","v8.15.3"],"title":"Update configuration on changes in category/advanced configurations in configView","number":195567,"url":"https://github.com/elastic/kibana/pull/195567","mergeCommit":{"message":"Update configuration on changes in category/advanced configurations in configView (#195567)\n\n## Closes https://github.com/elastic/search-team/issues/6557\r\n\r\n## Summary\r\n\r\nFixes a known bug for Network Drive connector (as this feature is only\r\nused in it). The problem happens when there are Rich Configurable Fields\r\nthat are marked as \"advanced\" and depend on certain fields - in some\r\ncases this field will not be shown until the page is fully reloaded.\r\n\r\nCriteria that makes the bug happen:\r\n\r\n1. Have some RCFs that are marked as \"advanced\":\r\nhttps://github.com/elastic/connectors/blob/main/connectors/sources/network_drive.py#L405-L414.\r\n(`\"ui_restrictions\": [\"advanced\"]`)\r\n2. Make it so that this RCF depends on another field, and by default is\r\nhidden - for example this field depends on a field \"OS\" that has\r\n\"Windows\" and \"Linux\" as available options and Windows is default, but\r\nthis RCF depends on it being \"Linux\"\r\n3. Try satisfying the dependency and see if the RCF is displayed - it\r\nwon't be, unless you save the form and reload it\r\n\r\nThe problem happens because for changes in \"advanced\" section the\r\nconfiguration is not updated, so the view that's rendered still thinks\r\nthat the dependency is not satisfied and the field should not be\r\nrendered\r\n\r\nBefore:\r\n\r\n\r\nhttps://github.com/user-attachments/assets/51f9f8b0-a57a-4d96-a183-6dbbd36a919e\r\n\r\nAfter:\r\n\r\n\r\nhttps://github.com/user-attachments/assets/be32f434-0810-4345-bc4e-dc82f617705c\r\n\r\n\r\n### Checklist\r\n\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"72c76f9ac9c43365bcfb70903c9d848012260291"}},"sourceBranch":"main","suggestedTargetBranches":["8.x","8.15"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195567","number":195567,"mergeCommit":{"message":"Update configuration on changes in category/advanced configurations in configView (#195567)\n\n## Closes https://github.com/elastic/search-team/issues/6557\r\n\r\n## Summary\r\n\r\nFixes a known bug for Network Drive connector (as this feature is only\r\nused in it). The problem happens when there are Rich Configurable Fields\r\nthat are marked as \"advanced\" and depend on certain fields - in some\r\ncases this field will not be shown until the page is fully reloaded.\r\n\r\nCriteria that makes the bug happen:\r\n\r\n1. Have some RCFs that are marked as \"advanced\":\r\nhttps://github.com/elastic/connectors/blob/main/connectors/sources/network_drive.py#L405-L414.\r\n(`\"ui_restrictions\": [\"advanced\"]`)\r\n2. Make it so that this RCF depends on another field, and by default is\r\nhidden - for example this field depends on a field \"OS\" that has\r\n\"Windows\" and \"Linux\" as available options and Windows is default, but\r\nthis RCF depends on it being \"Linux\"\r\n3. Try satisfying the dependency and see if the RCF is displayed - it\r\nwon't be, unless you save the form and reload it\r\n\r\nThe problem happens because for changes in \"advanced\" section the\r\nconfiguration is not updated, so the view that's rendered still thinks\r\nthat the dependency is not satisfied and the field should not be\r\nrendered\r\n\r\nBefore:\r\n\r\n\r\nhttps://github.com/user-attachments/assets/51f9f8b0-a57a-4d96-a183-6dbbd36a919e\r\n\r\nAfter:\r\n\r\n\r\nhttps://github.com/user-attachments/assets/be32f434-0810-4345-bc4e-dc82f617705c\r\n\r\n\r\n### Checklist\r\n\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"72c76f9ac9c43365bcfb70903c9d848012260291"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.15","label":"v8.15.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Artem Shelkovnikov <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Oct 10, 2024
…tions in configView (#195567) (#195707) # Backport This will backport the following commits from `main` to `8.15`: - [Update configuration on changes in category/advanced configurations in configView (#195567)](#195567) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Artem Shelkovnikov","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-10T07:34:17Z","message":"Update configuration on changes in category/advanced configurations in configView (#195567)\n\n## Closes https://github.com/elastic/search-team/issues/6557\r\n\r\n## Summary\r\n\r\nFixes a known bug for Network Drive connector (as this feature is only\r\nused in it). The problem happens when there are Rich Configurable Fields\r\nthat are marked as \"advanced\" and depend on certain fields - in some\r\ncases this field will not be shown until the page is fully reloaded.\r\n\r\nCriteria that makes the bug happen:\r\n\r\n1. Have some RCFs that are marked as \"advanced\":\r\nhttps://github.com/elastic/connectors/blob/main/connectors/sources/network_drive.py#L405-L414.\r\n(`\"ui_restrictions\": [\"advanced\"]`)\r\n2. Make it so that this RCF depends on another field, and by default is\r\nhidden - for example this field depends on a field \"OS\" that has\r\n\"Windows\" and \"Linux\" as available options and Windows is default, but\r\nthis RCF depends on it being \"Linux\"\r\n3. Try satisfying the dependency and see if the RCF is displayed - it\r\nwon't be, unless you save the form and reload it\r\n\r\nThe problem happens because for changes in \"advanced\" section the\r\nconfiguration is not updated, so the view that's rendered still thinks\r\nthat the dependency is not satisfied and the field should not be\r\nrendered\r\n\r\nBefore:\r\n\r\n\r\nhttps://github.com/user-attachments/assets/51f9f8b0-a57a-4d96-a183-6dbbd36a919e\r\n\r\nAfter:\r\n\r\n\r\nhttps://github.com/user-attachments/assets/be32f434-0810-4345-bc4e-dc82f617705c\r\n\r\n\r\n### Checklist\r\n\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"72c76f9ac9c43365bcfb70903c9d848012260291","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","v8.16.0","backport:version","v8.15.3"],"title":"Update configuration on changes in category/advanced configurations in configView","number":195567,"url":"https://github.com/elastic/kibana/pull/195567","mergeCommit":{"message":"Update configuration on changes in category/advanced configurations in configView (#195567)\n\n## Closes https://github.com/elastic/search-team/issues/6557\r\n\r\n## Summary\r\n\r\nFixes a known bug for Network Drive connector (as this feature is only\r\nused in it). The problem happens when there are Rich Configurable Fields\r\nthat are marked as \"advanced\" and depend on certain fields - in some\r\ncases this field will not be shown until the page is fully reloaded.\r\n\r\nCriteria that makes the bug happen:\r\n\r\n1. Have some RCFs that are marked as \"advanced\":\r\nhttps://github.com/elastic/connectors/blob/main/connectors/sources/network_drive.py#L405-L414.\r\n(`\"ui_restrictions\": [\"advanced\"]`)\r\n2. Make it so that this RCF depends on another field, and by default is\r\nhidden - for example this field depends on a field \"OS\" that has\r\n\"Windows\" and \"Linux\" as available options and Windows is default, but\r\nthis RCF depends on it being \"Linux\"\r\n3. Try satisfying the dependency and see if the RCF is displayed - it\r\nwon't be, unless you save the form and reload it\r\n\r\nThe problem happens because for changes in \"advanced\" section the\r\nconfiguration is not updated, so the view that's rendered still thinks\r\nthat the dependency is not satisfied and the field should not be\r\nrendered\r\n\r\nBefore:\r\n\r\n\r\nhttps://github.com/user-attachments/assets/51f9f8b0-a57a-4d96-a183-6dbbd36a919e\r\n\r\nAfter:\r\n\r\n\r\nhttps://github.com/user-attachments/assets/be32f434-0810-4345-bc4e-dc82f617705c\r\n\r\n\r\n### Checklist\r\n\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"72c76f9ac9c43365bcfb70903c9d848012260291"}},"sourceBranch":"main","suggestedTargetBranches":["8.x","8.15"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195567","number":195567,"mergeCommit":{"message":"Update configuration on changes in category/advanced configurations in configView (#195567)\n\n## Closes https://github.com/elastic/search-team/issues/6557\r\n\r\n## Summary\r\n\r\nFixes a known bug for Network Drive connector (as this feature is only\r\nused in it). The problem happens when there are Rich Configurable Fields\r\nthat are marked as \"advanced\" and depend on certain fields - in some\r\ncases this field will not be shown until the page is fully reloaded.\r\n\r\nCriteria that makes the bug happen:\r\n\r\n1. Have some RCFs that are marked as \"advanced\":\r\nhttps://github.com/elastic/connectors/blob/main/connectors/sources/network_drive.py#L405-L414.\r\n(`\"ui_restrictions\": [\"advanced\"]`)\r\n2. Make it so that this RCF depends on another field, and by default is\r\nhidden - for example this field depends on a field \"OS\" that has\r\n\"Windows\" and \"Linux\" as available options and Windows is default, but\r\nthis RCF depends on it being \"Linux\"\r\n3. Try satisfying the dependency and see if the RCF is displayed - it\r\nwon't be, unless you save the form and reload it\r\n\r\nThe problem happens because for changes in \"advanced\" section the\r\nconfiguration is not updated, so the view that's rendered still thinks\r\nthat the dependency is not satisfied and the field should not be\r\nrendered\r\n\r\nBefore:\r\n\r\n\r\nhttps://github.com/user-attachments/assets/51f9f8b0-a57a-4d96-a183-6dbbd36a919e\r\n\r\nAfter:\r\n\r\n\r\nhttps://github.com/user-attachments/assets/be32f434-0810-4345-bc4e-dc82f617705c\r\n\r\n\r\n### Checklist\r\n\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"72c76f9ac9c43365bcfb70903c9d848012260291"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.15","label":"v8.15.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Artem Shelkovnikov <[email protected]>
|
This PR didn't make it into the latest BC of v8.15.3. Updating the labels. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/elastic/search-team/issues/6557
Summary
Fixes a known bug for Network Drive connector (as this feature is only used in it). The problem happens when there are Rich Configurable Fields that are marked as "advanced" and depend on certain fields - in some cases this field will not be shown until the page is fully reloaded.
Criteria that makes the bug happen:
"ui_restrictions": ["advanced"])The problem happens because for changes in "advanced" section the configuration is not updated, so the view that's rendered still thinks that the dependency is not satisfied and the field should not be rendered
Before:
Screen.Recording.2024-10-09.at.14.29.58.mov
After:
Screen.Recording.2024-10-09.at.14.15.52.mov
Checklist
For maintainers
Release Note
Fixed a bug with the https://www.elastic.co/guide/en/enterprise-search/8.15/connectors-network-drive.html[Network Drive connector] where advanced configuration fields were not displayed for CSV file role mappings with
Drive Type: Linuxselected.