Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ftr] update svl roles and settings from controller #195563

Conversation

dmlemeshko
Copy link
Member

@dmlemeshko dmlemeshko commented Oct 9, 2024

Summary

Updating default roles for Oblt project and ES nodes settings for Security project to match elasticsearch-controller configuration

Adding obs teams for review to bring attention: we need to copy changes from controllers manually to make sure our serverless simulation in Kibana CI is close to real MKI env

@dmlemeshko dmlemeshko changed the title Ftr/update svl roles and settings from controller [Ftr] update svl roles and settings from controller Oct 9, 2024
@dmlemeshko dmlemeshko self-assigned this Oct 9, 2024
@dmlemeshko dmlemeshko added release_note:skip Skip the PR/issue when compiling release notes v9.0.0 FTR v8.16.0 backport:version Backport to applied version labels labels Oct 9, 2024
@dmlemeshko dmlemeshko requested review from a team October 9, 2024 10:25
@dmlemeshko dmlemeshko marked this pull request as ready for review October 9, 2024 10:29
@dmlemeshko dmlemeshko requested review from a team as code owners October 9, 2024 10:29
@wayneseymour
Copy link
Member

Should we cross link to what you mean here?

match elasticsearch-controller configuration

@dmlemeshko
Copy link
Member Author

dmlemeshko commented Oct 9, 2024

Should we cross link to what you mean here?

match elasticsearch-controller configuration

Nope :) controllers are private repos and decision was not to link it to Kibana. "if you know you know"

Copy link
Contributor

@cauemarcondes cauemarcondes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@tonyghiani tonyghiani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@pheyos pheyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pheyos
Copy link
Member

pheyos commented Oct 11, 2024

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

cc @dmlemeshko

@dmlemeshko dmlemeshko merged commit 4cd83b1 into elastic:main Oct 11, 2024
22 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11291008756

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 11, 2024
## Summary

Updating default roles for Oblt project and ES nodes settings for
Security project to match elasticsearch-controller configuration

Adding obs teams for review to bring attention: we need to copy changes
from controllers manually to make sure our serverless simulation in
Kibana CI is close to real MKI env

---------

Co-authored-by: Elastic Machine <[email protected]>
(cherry picked from commit 4cd83b1)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 11, 2024
…195885)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Ftr] update svl roles and settings from controller
(#195563)](#195563)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Dzmitry
Lemechko","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-11T10:48:17Z","message":"[Ftr]
update svl roles and settings from controller (#195563)\n\n##
Summary\r\n\r\nUpdating default roles for Oblt project and ES nodes
settings for\r\nSecurity project to match elasticsearch-controller
configuration\r\n\r\nAdding obs teams for review to bring attention: we
need to copy changes\r\nfrom controllers manually to make sure our
serverless simulation in\r\nKibana CI is close to real MKI
env\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine
<[email protected]>","sha":"4cd83b10d04b78d784a7ab7a6cf5212a69d4f1fa","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","FTR","apm:review","v8.16.0","backport:version"],"title":"[Ftr]
update svl roles and settings from
controller","number":195563,"url":"https://github.com/elastic/kibana/pull/195563","mergeCommit":{"message":"[Ftr]
update svl roles and settings from controller (#195563)\n\n##
Summary\r\n\r\nUpdating default roles for Oblt project and ES nodes
settings for\r\nSecurity project to match elasticsearch-controller
configuration\r\n\r\nAdding obs teams for review to bring attention: we
need to copy changes\r\nfrom controllers manually to make sure our
serverless simulation in\r\nKibana CI is close to real MKI
env\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine
<[email protected]>","sha":"4cd83b10d04b78d784a7ab7a6cf5212a69d4f1fa"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195563","number":195563,"mergeCommit":{"message":"[Ftr]
update svl roles and settings from controller (#195563)\n\n##
Summary\r\n\r\nUpdating default roles for Oblt project and ES nodes
settings for\r\nSecurity project to match elasticsearch-controller
configuration\r\n\r\nAdding obs teams for review to bring attention: we
need to copy changes\r\nfrom controllers manually to make sure our
serverless simulation in\r\nKibana CI is close to real MKI
env\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine
<[email protected]>","sha":"4cd83b10d04b78d784a7ab7a6cf5212a69d4f1fa"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Dzmitry Lemechko <[email protected]>
pheyos added a commit that referenced this pull request Oct 11, 2024
## Summary

This PR re-enables the serverless deployment agnostic tests

### Details

- The root cause of the problem should be fixed with #195563
- This reverts commit 8d1bc50

Closes #195811
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:review backport:version Backport to applied version labels FTR release_note:skip Skip the PR/issue when compiling release notes v8.16.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants