[Cloud Security] Refactoring, removed duplicated code from tests #195492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kfirpeled
added
release_note:skip
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#7110[✅] x-pack/test/cloud_security_posture_api/config.ts: 25/25 tests passed. |
opauloh
approved these changes
Oct 8, 2024
| * Checks if plugin initialization was done | ||
| * Required before indexing findings | ||
| */ | ||
| export const waitForPluginInitialized = ({ |
There was a problem hiding this comment.
nice enhancement, for the future I guess we can pass only the provider context and retrieve the parameters from it
There was a problem hiding this comment.
Well, sometimes you want them to have the same instance being passed, this approach provides that.
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11243585320 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 8, 2024
…stic#195492) ## Summary Removed duplicated code cloud_security_posture_api_integration tests folder ### Checklist - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed (cherry picked from commit 776f05a)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 8, 2024
#195492) (#195506) # Backport This will backport the following commits from `main` to `8.x`: - [[Cloud Security] Refactoring, removed duplicated code from tests (#195492)](#195492) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Kfir Peled","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-08T20:55:04Z","message":"[Cloud Security] Refactoring, removed duplicated code from tests (#195492)\n\n## Summary\r\n\r\nRemoved duplicated code cloud_security_posture_api_integration tests\r\nfolder\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed","sha":"776f05a1b017d333f33ccd915c7fbc2a81e838fd","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor"],"title":"[Cloud Security] Refactoring, removed duplicated code from tests","number":195492,"url":"https://github.com/elastic/kibana/pull/195492","mergeCommit":{"message":"[Cloud Security] Refactoring, removed duplicated code from tests (#195492)\n\n## Summary\r\n\r\nRemoved duplicated code cloud_security_posture_api_integration tests\r\nfolder\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed","sha":"776f05a1b017d333f33ccd915c7fbc2a81e838fd"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195492","number":195492,"mergeCommit":{"message":"[Cloud Security] Refactoring, removed duplicated code from tests (#195492)\n\n## Summary\r\n\r\nRemoved duplicated code cloud_security_posture_api_integration tests\r\nfolder\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed","sha":"776f05a1b017d333f33ccd915c7fbc2a81e838fd"}}]}] BACKPORT--> Co-authored-by: Kfir Peled <[email protected]>
|
Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removed duplicated code cloud_security_posture_api_integration tests folder
Checklist