Remove padding that exists only in 6.x but not master #19547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💔 Build Failed |
…that isn't intentional
stacey-gammon
force-pushed
the
2018-05-6-x-remove-extra-padding
branch
from
bc12367 to
5694797
Compare
snide
approved these changes
May 30, 2018
💚 Build Succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like #14811 introduce a line for panel-content that is
padding: 0 8px 8px 8px. This was backported to 6.x. The next PR to touch that file was #14831. This PR removed the line in master, but left it in the backport. I think this was just a mistake.The question is, should the padding be there or not? It looks like it was mistakenly removed from master... but I think it actually looks better without, especially given some of the negative feedback we've had with too much padding.
With padding:
Without:
This PR removes the padding from 6.x to bring the two branches in sync again.