Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Update publicBaseUrl and rewriteBasePath settings #195465

Merged

Conversation

TinaHeiligers
Copy link
Contributor

@TinaHeiligers TinaHeiligers commented Oct 8, 2024

fix #114562

Screenshot 2024-10-08 at 09 04 20

Screenshot 2024-10-08 at 09 04 49

Copy link
Contributor

github-actions bot commented Oct 8, 2024

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@TinaHeiligers TinaHeiligers added docs backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) v8.16.0 release_note:skip Skip the PR/issue when compiling release notes labels Oct 8, 2024
@TinaHeiligers TinaHeiligers requested review from KOTungseth and florent-leborgne and removed request for KOTungseth October 8, 2024 16:11
Copy link
Contributor

@lcawl lcawl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor edits, otherwise LGTM

docs/setup/settings.asciidoc Outdated Show resolved Hide resolved
docs/setup/settings.asciidoc Outdated Show resolved Hide resolved
@TinaHeiligers TinaHeiligers removed the request for review from florent-leborgne October 8, 2024 22:52
@TinaHeiligers TinaHeiligers enabled auto-merge (squash) October 8, 2024 22:52
@TinaHeiligers TinaHeiligers merged commit 7839db9 into elastic:main Oct 8, 2024
8 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11245215682

@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 8, 2024
…) (#195520)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Docs] Update publicBaseUrl and rewriteBasePath settings
(#195465)](#195465)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Christiane (Tina)
Heiligers","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-08T23:14:28Z","message":"[Docs]
Update publicBaseUrl and rewriteBasePath settings (#195465)\n\nfix
https://github.com/elastic/kibana/issues/114562\r\n\r\n![Screenshot
2024-10-08 at 09
04\r\n20](https://github.com/user-attachments/assets/f43d592d-cc49-4f41-9bee-2a85f9c08292)\r\n\r\n![Screenshot
2024-10-08 at 09
04\r\n49](https://github.com/user-attachments/assets/39184960-d5ec-4485-944b-6ef4295d7101)\r\n\r\n---------\r\n\r\nCo-authored-by:
Lisa Cawley
<[email protected]>","sha":"7839db950e92d2dc41b53115e3d63ef0adb4755f","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","docs","backport:prev-minor","v8.16.0"],"title":"[Docs]
Update publicBaseUrl and rewriteBasePath
settings","number":195465,"url":"https://github.com/elastic/kibana/pull/195465","mergeCommit":{"message":"[Docs]
Update publicBaseUrl and rewriteBasePath settings (#195465)\n\nfix
https://github.com/elastic/kibana/issues/114562\r\n\r\n![Screenshot
2024-10-08 at 09
04\r\n20](https://github.com/user-attachments/assets/f43d592d-cc49-4f41-9bee-2a85f9c08292)\r\n\r\n![Screenshot
2024-10-08 at 09
04\r\n49](https://github.com/user-attachments/assets/39184960-d5ec-4485-944b-6ef4295d7101)\r\n\r\n---------\r\n\r\nCo-authored-by:
Lisa Cawley
<[email protected]>","sha":"7839db950e92d2dc41b53115e3d63ef0adb4755f"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195465","number":195465,"mergeCommit":{"message":"[Docs]
Update publicBaseUrl and rewriteBasePath settings (#195465)\n\nfix
https://github.com/elastic/kibana/issues/114562\r\n\r\n![Screenshot
2024-10-08 at 09
04\r\n20](https://github.com/user-attachments/assets/f43d592d-cc49-4f41-9bee-2a85f9c08292)\r\n\r\n![Screenshot
2024-10-08 at 09
04\r\n49](https://github.com/user-attachments/assets/39184960-d5ec-4485-944b-6ef4295d7101)\r\n\r\n---------\r\n\r\nCo-authored-by:
Lisa Cawley
<[email protected]>","sha":"7839db950e92d2dc41b53115e3d63ef0adb4755f"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Christiane (Tina) Heiligers <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) docs release_note:skip Skip the PR/issue when compiling release notes v8.16.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update rewriteBasePath documentation
3 participants