[Synthetics] Test useMonitorStatusData hook
#195438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
ci:project-deploy-observability
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
justinkambic
added
release_note:skip
justinkambic
force-pushed
the
test-use-monitor-status-data
branch
from
7b47cb7 to
386d2d9
Compare
💛 Build succeeded, but was flaky
Failed CI StepsTest FailuresMetrics [docs]Async chunks
History
|
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11369772699 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 16, 2024
## Summary Recently we had some issues related to module-level logic errors in a fairly complicated hook. This PR adds a new jest suite for the hook in question that covers some baseline usage. It could be improved in the future with additional test cases. (cherry picked from commit 4605cc0)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 16, 2024
… (#196575) # Backport This will backport the following commits from `main` to `8.x`: - [[Synthetics] Test `useMonitorStatusData` hook (#195438)](#195438) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Justin Kambic","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-16T16:21:48Z","message":"[Synthetics] Test `useMonitorStatusData` hook (#195438)\n\n## Summary\r\n\r\nRecently we had some issues related to module-level logic errors in a\r\nfairly complicated hook.\r\n\r\nThis PR adds a new jest suite for the hook in question that covers some\r\nbaseline usage. It could be improved in the future with additional test\r\ncases.","sha":"4605cc03074aad77dba7b7ceadd691fc80f9cc58","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-management","v8.17.0"],"title":"[Synthetics] Test `useMonitorStatusData` hook","number":195438,"url":"https://github.com/elastic/kibana/pull/195438","mergeCommit":{"message":"[Synthetics] Test `useMonitorStatusData` hook (#195438)\n\n## Summary\r\n\r\nRecently we had some issues related to module-level logic errors in a\r\nfairly complicated hook.\r\n\r\nThis PR adds a new jest suite for the hook in question that covers some\r\nbaseline usage. It could be improved in the future with additional test\r\ncases.","sha":"4605cc03074aad77dba7b7ceadd691fc80f9cc58"}},"sourceBranch":"main","suggestedTargetBranches":["8.17"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195438","number":195438,"mergeCommit":{"message":"[Synthetics] Test `useMonitorStatusData` hook (#195438)\n\n## Summary\r\n\r\nRecently we had some issues related to module-level logic errors in a\r\nfairly complicated hook.\r\n\r\nThis PR adds a new jest suite for the hook in question that covers some\r\nbaseline usage. It could be improved in the future with additional test\r\ncases.","sha":"4605cc03074aad77dba7b7ceadd691fc80f9cc58"}},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Justin Kambic <[email protected]>
hop-dev
pushed a commit
to hop-dev/kibana
that referenced
this pull request
Oct 17, 2024
## Summary Recently we had some issues related to module-level logic errors in a fairly complicated hook. This PR adds a new jest suite for the hook in question that covers some baseline usage. It could be improved in the future with additional test cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Recently we had some issues related to module-level logic errors in a fairly complicated hook.
This PR adds a new jest suite for the hook in question that covers some baseline usage. It could be improved in the future with additional test cases.