[Synthetics] Refactor bulk delete monitor and params routes !! #195420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shahzad31
added
backport:prev-minor
botelastic
bot
added
ci:project-deploy-observability
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
jloleysens
reviewed
Oct 9, 2024
| @@ -37,7 +37,7 @@ DELETE /api/synthetics/monitors/monitor1-id | |||
|
|
|||
| ==== Bulk Delete Monitors | |||
|
|
|||
| You can delete multiple monitors by sending a list of config ids to a DELETE request to the `/api/synthetics/monitors` endpoint. | |||
| You can delete multiple monitors by sending a list of config ids to a POST request to the `/api/synthetics/monitors/_bulk_delete` endpoint. | |||
There was a problem hiding this comment.
Because these routes are publicly documented we will need to first deprecate the existing route and expose a the new /_bulk_delete route. And before we implement a deprecation we need to get it reviewed.
There was a problem hiding this comment.
My understanding is that now that we aren't deprecating the api/synthetics/monitors route, but just crating a new _bulk_delete route, we do not need to do this. Is that correct?
dominiqueclarke
requested review from
dominiqueclarke
and removed request for
dominiqueclarke
dominiqueclarke
requested changes
Nov 1, 2024
There was a problem hiding this comment.
Delete monitor looks good
Deleting a param leads to error
https://www.loom.com/share/59022fd92eb34f3b91076a8035fabc8e?sid=b22e242d-da29-4d26-a221-8d2aedb3f952
Error was 400 bad request.
{
"statusCode": 400,
"error": "Bad Request",
"message": "[request body]: types that failed validation:\n- [request body.0.key]: expected value of type [string] but got [undefined]\n- [request body.1]: expected value of type [array] but got [Object]"
}
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
shahzad31
removed
the
backport:prev-minor
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11720558634 |
shahzad31
added
backport:version
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11720567047 |
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11720567048 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 7, 2024
…ic#195420) ## Summary Refactor bulk delete monitor and params routes !! We need to remove usage for body from DELETE route. ### Params Params can be bulk delete now with POST request to `/params/_bulk_delete` endpoint ### Monitors Monitors can be bulk delete now with POST request to `/monitors/_bulk_delete` endpoint (cherry picked from commit d25a2b4)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 7, 2024
…ic#195420) ## Summary Refactor bulk delete monitor and params routes !! We need to remove usage for body from DELETE route. ### Params Params can be bulk delete now with POST request to `/params/_bulk_delete` endpoint ### Monitors Monitors can be bulk delete now with POST request to `/monitors/_bulk_delete` endpoint (cherry picked from commit d25a2b4)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 7, 2024
…ic#195420) ## Summary Refactor bulk delete monitor and params routes !! We need to remove usage for body from DELETE route. ### Params Params can be bulk delete now with POST request to `/params/_bulk_delete` endpoint ### Monitors Monitors can be bulk delete now with POST request to `/monitors/_bulk_delete` endpoint (cherry picked from commit d25a2b4)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 7, 2024
…195420) (#199277) # Backport This will backport the following commits from `main` to `8.x`: - [[Synthetics] Refactor bulk delete monitor and params routes !! (#195420)](#195420) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Shahzad","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-07T09:51:56Z","message":"[Synthetics] Refactor bulk delete monitor and params routes !! (#195420)\n\n## Summary\r\n\r\nRefactor bulk delete monitor and params routes !! \r\n\r\nWe need to remove usage for body from DELETE route.\r\n\r\n### Params\r\n\r\nParams can be bulk delete now with POST request to\r\n`/params/_bulk_delete` endpoint\r\n\r\n### Monitors\r\nMonitors can be bulk delete now with POST request to\r\n`/monitors/_bulk_delete` endpoint","sha":"d25a2b442aff8d3b4559832257b98c0f50de922b","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","ci:project-deploy-observability","Team:obs-ux-management"],"title":"[Synthetics] Refactor bulk delete monitor and params routes !!","number":195420,"url":"https://github.com/elastic/kibana/pull/195420","mergeCommit":{"message":"[Synthetics] Refactor bulk delete monitor and params routes !! (#195420)\n\n## Summary\r\n\r\nRefactor bulk delete monitor and params routes !! \r\n\r\nWe need to remove usage for body from DELETE route.\r\n\r\n### Params\r\n\r\nParams can be bulk delete now with POST request to\r\n`/params/_bulk_delete` endpoint\r\n\r\n### Monitors\r\nMonitors can be bulk delete now with POST request to\r\n`/monitors/_bulk_delete` endpoint","sha":"d25a2b442aff8d3b4559832257b98c0f50de922b"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195420","number":195420,"mergeCommit":{"message":"[Synthetics] Refactor bulk delete monitor and params routes !! (#195420)\n\n## Summary\r\n\r\nRefactor bulk delete monitor and params routes !! \r\n\r\nWe need to remove usage for body from DELETE route.\r\n\r\n### Params\r\n\r\nParams can be bulk delete now with POST request to\r\n`/params/_bulk_delete` endpoint\r\n\r\n### Monitors\r\nMonitors can be bulk delete now with POST request to\r\n`/monitors/_bulk_delete` endpoint","sha":"d25a2b442aff8d3b4559832257b98c0f50de922b"}}]}] BACKPORT--> Co-authored-by: Shahzad <[email protected]>
mbondyra
pushed a commit
to mbondyra/kibana
that referenced
this pull request
Nov 8, 2024
…ic#195420) ## Summary Refactor bulk delete monitor and params routes !! We need to remove usage for body from DELETE route. ### Params Params can be bulk delete now with POST request to `/params/_bulk_delete` endpoint ### Monitors Monitors can be bulk delete now with POST request to `/monitors/_bulk_delete` endpoint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactor bulk delete monitor and params routes !!
We need to remove usage for body from DELETE route.
Params
Params can be bulk delete now with POST request to
/params/_bulk_deleteendpointMonitors
Monitors can be bulk delete now with POST request to
/monitors/_bulk_deleteendpoint