[ES|QL][Inspector] Display cluster details tab for CCS data sources #195373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stratoula
added
release_note:enhancement
v9.0.0
v8.16.0
Feature:ES|QL
stratoula
changed the title
💚 Build Succeeded
Metrics [docs]Page load bundle
|
|
Pinging @elastic/kibana-esql (Team:ESQL) |
stratoula
added
the
backport:prev-minor
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11273188939 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 10, 2024
…lastic#195373) ## Summary It displays correctly the cluster details if they come in the response. To test it you will need a CCS index as the `_clusters` property only comes for these indexes. Other than that it just works out of the bloom as the response is exactly the same as the search api. If we were sending the response correctly in the inspector (it wants: `rawResonse: {....}` and not just the response as we get it), it would have worked without any change from our side.  (cherry picked from commit a6e22cf)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 10, 2024
…rces (#195373) (#195750) # Backport This will backport the following commits from `main` to `8.x`: - [[ES|QL][Inspector] Display cluster details tab for CCS data sources (#195373)](#195373) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Stratoula Kalafateli","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-10T11:33:41Z","message":"[ES|QL][Inspector] Display cluster details tab for CCS data sources (#195373)\n\n## Summary\r\n\r\nIt displays correctly the cluster details if they come in the response.\r\nTo test it you will need a CCS index as the `_clusters` property only\r\ncomes for these indexes.\r\n\r\nOther than that it just works out of the bloom as the response is\r\nexactly the same as the search api. If we were sending the response\r\ncorrectly in the inspector (it wants: `rawResonse: {....}` and not just\r\nthe response as we get it), it would have worked without any change from\r\nour side.\r\n\r\n","sha":"a6e22cf581975cab828b62926484dc2104a19432","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement","v9.0.0","backport:prev-minor","Feature:ES|QL","Team:ESQL","v8.16.0"],"title":"[ES|QL][Inspector] Display cluster details tab for CCS data sources","number":195373,"url":"https://github.com/elastic/kibana/pull/195373","mergeCommit":{"message":"[ES|QL][Inspector] Display cluster details tab for CCS data sources (#195373)\n\n## Summary\r\n\r\nIt displays correctly the cluster details if they come in the response.\r\nTo test it you will need a CCS index as the `_clusters` property only\r\ncomes for these indexes.\r\n\r\nOther than that it just works out of the bloom as the response is\r\nexactly the same as the search api. If we were sending the response\r\ncorrectly in the inspector (it wants: `rawResonse: {....}` and not just\r\nthe response as we get it), it would have worked without any change from\r\nour side.\r\n\r\n","sha":"a6e22cf581975cab828b62926484dc2104a19432"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195373","number":195373,"mergeCommit":{"message":"[ES|QL][Inspector] Display cluster details tab for CCS data sources (#195373)\n\n## Summary\r\n\r\nIt displays correctly the cluster details if they come in the response.\r\nTo test it you will need a CCS index as the `_clusters` property only\r\ncomes for these indexes.\r\n\r\nOther than that it just works out of the bloom as the response is\r\nexactly the same as the search api. If we were sending the response\r\ncorrectly in the inspector (it wants: `rawResonse: {....}` and not just\r\nthe response as we get it), it would have worked without any change from\r\nour side.\r\n\r\n","sha":"a6e22cf581975cab828b62926484dc2104a19432"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Stratoula Kalafateli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It displays correctly the cluster details if they come in the response. To test it you will need a CCS index as the
_clustersproperty only comes for these indexes.Other than that it just works out of the bloom as the response is exactly the same as the search api. If we were sending the response correctly in the inspector (it wants:
rawResonse: {....}and not just the response as we get it), it would have worked without any change from our side.