Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Add cypress test against space awareness #195372

Merged
merged 11 commits into from
Oct 11, 2024

Conversation

nchaulet
Copy link
Member

@nchaulet nchaulet commented Oct 8, 2024

Summary

Resolve #193071

Add a new test suite to test Fleet with space awareness enabled.

Add a test that create an agent policy in one space, verify it's not accessible in an other space, and then assign that policies to both space and verify it's accessible in both space.

I had to change the change run_parallel script to support the excludeSpecPattern option

@nchaulet nchaulet added release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) v8.16.0 labels Oct 8, 2024
@nchaulet nchaulet self-assigned this Oct 8, 2024
@nchaulet nchaulet force-pushed the feature-space-cypress-tests branch 2 times, most recently from 8d0e7da to 2cfd9d5 Compare October 8, 2024 11:10
@nchaulet nchaulet force-pushed the feature-space-cypress-tests branch from 2cfd9d5 to 5852433 Compare October 8, 2024 11:10
@nchaulet nchaulet marked this pull request as ready for review October 9, 2024 07:33
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

Copy link
Contributor

@juliaElastic juliaElastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nchaulet
Copy link
Member Author

nchaulet commented Oct 9, 2024

@elasticmachine merge upstream

@nchaulet
Copy link
Member Author

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 1.7MB 1.7MB +128.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
fleet 45 47 +2

Total ESLint disabled count

id before after diff
fleet 57 59 +2

History

cc @nchaulet

Copy link
Contributor

@maximpn maximpn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

x-pack/plugins/security_solution/scripts/run_cypress/parallel.ts changes LGTM

@nchaulet nchaulet merged commit 5b69749 into elastic:main Oct 11, 2024
43 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11288069860

@nchaulet nchaulet deleted the feature-space-cypress-tests branch October 11, 2024 07:19
@nchaulet nchaulet restored the feature-space-cypress-tests branch October 11, 2024 07:19
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.x Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 195372

Questions ?

Please refer to the Backport tool documentation

@nchaulet
Copy link
Member Author

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

nchaulet added a commit to nchaulet/kibana that referenced this pull request Oct 11, 2024
(cherry picked from commit 5b69749)

# Conflicts:
#	x-pack/plugins/fleet/cypress/tsconfig.json
@nchaulet nchaulet deleted the feature-space-cypress-tests branch October 11, 2024 09:53
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 14, 2024
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

1 similar comment
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

nchaulet added a commit that referenced this pull request Oct 15, 2024
…5873)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Fleet] Add cypress test against space awareness
(#195372)](#195372)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Nicolas
Chaulet","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-11T07:19:21Z","message":"[Fleet]
Add cypress test against space awareness
(#195372)","sha":"5b697499978170937d8c0280b0cf184ee84b57ab","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v9.0.0","backport:prev-minor","v8.16.0"],"number":195372,"url":"https://github.com/elastic/kibana/pull/195372","mergeCommit":{"message":"[Fleet]
Add cypress test against space awareness
(#195372)","sha":"5b697499978170937d8c0280b0cf184ee84b57ab"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195372","number":195372,"mergeCommit":{"message":"[Fleet]
Add cypress test against space awareness
(#195372)","sha":"5b697499978170937d8c0280b0cf184ee84b57ab"}},{"branch":"8.x","label":"v8.16.0","labelRegex":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Elastic Machine <[email protected]>
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.16.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Fleet] Add cypress tests with space awareness enabled
6 participants