[Index Management] Fix filter index list by lifecycle status #195350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@elasticmachine merge upstream |
ElenaStoeva
approved these changes
Oct 8, 2024
There was a problem hiding this comment.
Thanks for patching this up @viajes7! Tested locally and the filter works as expected now. Code changes also lgtm.
I was curious why only_managed was set to true initially and found that this was added in #176178, but it doesn't explain why it sets the response from ES to only return ILM data for indices that are managed by ILM. I tested the scenario from that PR and it still works well, so I think we're good to merge this change! 👍
ElenaStoeva
added
Team:Kibana Management
|
Pinging @elastic/kibana-management (Team:Kibana Management) |
ElenaStoeva
added
the
release_note:skip
|
/ci |
|
@elasticmachine merge upstream |
|
/ci |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History
|
|
@elasticmachine run docs-build |
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11277801837 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 10, 2024
…#195350) ## Summary Fixes elastic#180970 In `indexLifecycleDataEnricher`, add `only_managed: true` query parameter to fetch lifecycle data. It causes the `ilm` property to be empty in the response. And `EuiSearchBar` `field_value_selection` doesn't support filtering a `undefined` filed value. So, maybe `only_managed: true` should be removed. Before: <img width="733" alt="image" src="https://github.com/user-attachments/assets/2472127d-c050-4ffb-bb76-f3e80e780cb3"> After: <img width="511" alt="image" src="https://github.com/user-attachments/assets/da38f437-58f4-43b2-8d6b-54873e01f79b"> Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elena Stoeva <[email protected]> (cherry picked from commit 5214877)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 10, 2024
…195350) (#195803) # Backport This will backport the following commits from `main` to `8.x`: - [[Index Management] Fix filter index list by lifecycle status (#195350)](#195350) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Jusheng Huang","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-10T16:05:23Z","message":"[Index Management] Fix filter index list by lifecycle status (#195350)\n\n## Summary\r\n\r\nFixes #180970 \r\n\r\nIn `indexLifecycleDataEnricher`, add `only_managed: true` query\r\nparameter to fetch lifecycle data.\r\n\r\nIt causes the `ilm` property to be empty in the response. And\r\n`EuiSearchBar` `field_value_selection` doesn't support filtering a\r\n`undefined` filed value.\r\n\r\nSo, maybe `only_managed: true` should be removed.\r\n\r\nBefore:\r\n\r\n<img width=\"733\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/2472127d-c050-4ffb-bb76-f3e80e780cb3\">\r\n\r\nAfter: \r\n\r\n<img width=\"511\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/da38f437-58f4-43b2-8d6b-54873e01f79b\">\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>\r\nCo-authored-by: Elena Stoeva <[email protected]>","sha":"52148775b1ff4b4379f0049cc2332fb27e405a07","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Kibana Management","release_note:skip","💝community","v9.0.0","backport:prev-minor"],"title":"[Index Management] Fix filter index list by lifecycle status","number":195350,"url":"https://github.com/elastic/kibana/pull/195350","mergeCommit":{"message":"[Index Management] Fix filter index list by lifecycle status (#195350)\n\n## Summary\r\n\r\nFixes #180970 \r\n\r\nIn `indexLifecycleDataEnricher`, add `only_managed: true` query\r\nparameter to fetch lifecycle data.\r\n\r\nIt causes the `ilm` property to be empty in the response. And\r\n`EuiSearchBar` `field_value_selection` doesn't support filtering a\r\n`undefined` filed value.\r\n\r\nSo, maybe `only_managed: true` should be removed.\r\n\r\nBefore:\r\n\r\n<img width=\"733\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/2472127d-c050-4ffb-bb76-f3e80e780cb3\">\r\n\r\nAfter: \r\n\r\n<img width=\"511\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/da38f437-58f4-43b2-8d6b-54873e01f79b\">\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>\r\nCo-authored-by: Elena Stoeva <[email protected]>","sha":"52148775b1ff4b4379f0049cc2332fb27e405a07"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195350","number":195350,"mergeCommit":{"message":"[Index Management] Fix filter index list by lifecycle status (#195350)\n\n## Summary\r\n\r\nFixes #180970 \r\n\r\nIn `indexLifecycleDataEnricher`, add `only_managed: true` query\r\nparameter to fetch lifecycle data.\r\n\r\nIt causes the `ilm` property to be empty in the response. And\r\n`EuiSearchBar` `field_value_selection` doesn't support filtering a\r\n`undefined` filed value.\r\n\r\nSo, maybe `only_managed: true` should be removed.\r\n\r\nBefore:\r\n\r\n<img width=\"733\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/2472127d-c050-4ffb-bb76-f3e80e780cb3\">\r\n\r\nAfter: \r\n\r\n<img width=\"511\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/da38f437-58f4-43b2-8d6b-54873e01f79b\">\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>\r\nCo-authored-by: Elena Stoeva <[email protected]>","sha":"52148775b1ff4b4379f0049cc2332fb27e405a07"}}]}] BACKPORT--> Co-authored-by: Jusheng Huang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #180970
In
indexLifecycleDataEnricher, addonly_managed: truequery parameter to fetch lifecycle data.It causes the
ilmproperty to be empty in the response. AndEuiSearchBarfield_value_selectiondoesn't support filtering aundefinedfiled value.So, maybe
only_managed: trueshould be removed.Before:
After: