Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] [Dashboard] Await new services in exported listing table (#195277) #195301

Merged
merged 1 commit into from
Oct 7, 2024
Merged

[8.x] [Dashboard] Await new services in exported listing table (#195277) #195301

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/plugins/dashboard/public/dashboard_listing/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,10 @@
* License v3.0 only", or the "Server Side Public License, v 1".
*/

import React, { Suspense } from 'react';
import { EuiEmptyPrompt, EuiLoadingSpinner } from '@elastic/eui';
import React, { Suspense } from 'react';

import { servicesReady } from '../plugin';
import { untilPluginStartServicesReady } from '../services/kibana_services';
import { DashboardListingProps } from './types';

const ListingTableLoadingIndicator = () => {
Expand All @@ -20,7 +20,7 @@ const ListingTableLoadingIndicator = () => {
const LazyDashboardListing = React.lazy(() =>
(async () => {
const modulePromise = import('./dashboard_listing_table');
const [module] = await Promise.all([modulePromise, servicesReady]);
const [module] = await Promise.all([modulePromise, untilPluginStartServicesReady()]);

return {
default: module.DashboardListingTable,
Expand Down
1 change: 0 additions & 1 deletion src/plugins/dashboard/public/plugin.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,6 @@ export interface DashboardStart {
}

export let resolveServicesReady: () => void;
export const servicesReady = new Promise<void>((resolve) => (resolveServicesReady = resolve));

export class DashboardPlugin
implements
Expand Down