[Console] Only suggest dot-prefixed indices when user types a dot #195283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElenaStoeva
added
Feature:Console
|
Pinging @elastic/kibana-management (Team:Kibana Management) |
💚 Build Succeeded
Metrics [docs]Async chunks
cc @ElenaStoeva |
sabarasaba
approved these changes
Oct 9, 2024
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11256461791 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 9, 2024
…astic#195283) Closes elastic#194801 ## Summary This PR filters the Console autocomplete suggestions in the URL path so that dot-prefixed indices are suggested only if a dot is typed in. https://github.com/user-attachments/assets/fe7fc155-f9a8-4fb0-953e-b84b0d052f2a (cherry picked from commit c20f655)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 9, 2024
…ot (#195283) (#195606) # Backport This will backport the following commits from `main` to `8.x`: - [[Console] Only suggest dot-prefixed indices when user types a dot (#195283)](#195283) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Elena Stoeva","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-09T13:53:55Z","message":"[Console] Only suggest dot-prefixed indices when user types a dot (#195283)\n\nCloses https://github.com/elastic/kibana/issues/194801\r\n\r\n## Summary\r\n\r\nThis PR filters the Console autocomplete suggestions in the URL path so\r\nthat dot-prefixed indices are suggested only if a dot is typed in.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/fe7fc155-f9a8-4fb0-953e-b84b0d052f2a","sha":"c20f6550126b05937c1faaf105dd2425fc57f861","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Console","Team:Kibana Management","release_note:skip","v9.0.0","backport:prev-minor"],"title":"[Console] Only suggest dot-prefixed indices when user types a dot","number":195283,"url":"https://github.com/elastic/kibana/pull/195283","mergeCommit":{"message":"[Console] Only suggest dot-prefixed indices when user types a dot (#195283)\n\nCloses https://github.com/elastic/kibana/issues/194801\r\n\r\n## Summary\r\n\r\nThis PR filters the Console autocomplete suggestions in the URL path so\r\nthat dot-prefixed indices are suggested only if a dot is typed in.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/fe7fc155-f9a8-4fb0-953e-b84b0d052f2a","sha":"c20f6550126b05937c1faaf105dd2425fc57f861"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195283","number":195283,"mergeCommit":{"message":"[Console] Only suggest dot-prefixed indices when user types a dot (#195283)\n\nCloses https://github.com/elastic/kibana/issues/194801\r\n\r\n## Summary\r\n\r\nThis PR filters the Console autocomplete suggestions in the URL path so\r\nthat dot-prefixed indices are suggested only if a dot is typed in.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/fe7fc155-f9a8-4fb0-953e-b84b0d052f2a","sha":"c20f6550126b05937c1faaf105dd2425fc57f861"}}]}] BACKPORT--> Co-authored-by: Elena Stoeva <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #194801
Summary
This PR filters the Console autocomplete suggestions in the URL path so that dot-prefixed indices are suggested only if a dot is typed in.
Screen.Recording.2024-10-09.at.12.32.50.mov