Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Console] Disable export if no content #195178

Merged

Conversation

sabarasaba
Copy link
Member

@sabarasaba sabarasaba commented Oct 7, 2024

Fixes #195117

Summary

This PR disables the export request button if there isnt anything to export.

@sabarasaba sabarasaba added Feature:Console Dev Tools Console Feature Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Oct 7, 2024
@sabarasaba sabarasaba self-assigned this Oct 7, 2024
@sabarasaba sabarasaba requested a review from ElenaStoeva October 7, 2024 07:32
@sabarasaba sabarasaba marked this pull request as ready for review October 7, 2024 09:14
@sabarasaba sabarasaba requested a review from a team as a code owner October 7, 2024 09:14
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-management (Team:Kibana Management)

@sabarasaba
Copy link
Member Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #11 / FilesUtilityBar search text passed correctly to callback

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
console 208.1KB 208.1KB +16.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @sabarasaba

Copy link
Contributor

@ElenaStoeva ElenaStoeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! Tested locally, changes lgtm.

@sabarasaba sabarasaba merged commit 76e4ffa into elastic:main Oct 7, 2024
22 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11214623300

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 7, 2024
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 7, 2024
# Backport

This will backport the following commits from `main` to `8.x`:
- [[Console] Disable export if no content
(#195178)](#195178)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Ignacio
Rivas","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-07T11:33:14Z","message":"[Console]
Disable export if no content
(#195178)","sha":"76e4ffa0c9628d7b71400043e39c9c5973d34b7d","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Console","Team:Kibana
Management","release_note:skip","v9.0.0","backport:prev-minor"],"title":"[Console]
Disable export if no
content","number":195178,"url":"https://github.com/elastic/kibana/pull/195178","mergeCommit":{"message":"[Console]
Disable export if no content
(#195178)","sha":"76e4ffa0c9628d7b71400043e39c9c5973d34b7d"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195178","number":195178,"mergeCommit":{"message":"[Console]
Disable export if no content
(#195178)","sha":"76e4ffa0c9628d7b71400043e39c9c5973d34b7d"}}]}]
BACKPORT-->

Co-authored-by: Ignacio Rivas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Feature:Console Dev Tools Console Feature release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v8.16.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Serverless-observability] Console lets users export empty requests
5 participants