[Synthetics] Fix ping heatmap payload #195107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinkambic
added
bug
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
botelastic
bot
added
the
ci:project-deploy-observability
justinkambic
force-pushed
the
fix-heatmap-again-again
branch
from
46cc49f
to
8e97aec
Compare
shahzad31
approved these changes
Oct 7, 2024
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History |
|
Starting backport for target branches: 8.15, 8.x https://github.com/elastic/kibana/actions/runs/11237971580 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 8, 2024
## Summary We addressed elastic#180076 recently with these two PRs: - elastic#184177 - elastic#192508 We were seeing a strange error that was difficult to repro, so we put in a best-effort patch that was still ineffective. The reason this issue happens is because in the code it's possible to divide by 0, which yields a value of `Infinity`, which at some point causes our interval value supplied to the server route to be an empty string. This patch will make it so that we never pass a value of 0 to be used in the calculation of bucket sizes in this hook. (cherry picked from commit 560d561)
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
justinkambic
added
backport:prev-minor
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11238927793 |
|
Initially this was labeled to backport to |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 8, 2024
## Summary We addressed elastic#180076 recently with these two PRs: - elastic#184177 - elastic#192508 We were seeing a strange error that was difficult to repro, so we put in a best-effort patch that was still ineffective. The reason this issue happens is because in the code it's possible to divide by 0, which yields a value of `Infinity`, which at some point causes our interval value supplied to the server route to be an empty string. This patch will make it so that we never pass a value of 0 to be used in the calculation of bucket sizes in this hook. (cherry picked from commit 560d561)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 8, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [[Synthetics] Fix ping heatmap payload (#195107)](#195107) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Justin Kambic","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-08T14:46:30Z","message":"[Synthetics] Fix ping heatmap payload (#195107)\n\n## Summary\r\n\r\nWe addressed #180076 recently\r\nwith these two PRs:\r\n\r\n- https://github.com/elastic/kibana/pull/184177\r\n- https://github.com/elastic/kibana/pull/192508\r\n\r\nWe were seeing a strange error that was difficult to repro, so we put in\r\na best-effort patch that was still ineffective. The reason this issue\r\nhappens is because in the code it's possible to divide by 0, which\r\nyields a value of `Infinity`, which at some point causes our interval\r\nvalue supplied to the server route to be an empty string.\r\n\r\nThis patch will make it so that we never pass a value of 0 to be used in\r\nthe calculation of bucket sizes in this hook.","sha":"560d561e21fe51020954bd9e3246f238ffa026ba","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","v9.0.0","backport:prev-major","ci:project-deploy-observability","Team:obs-ux-management","v8.16.0","v8.15.3"],"title":"[Synthetics] Fix ping heatmap payload","number":195107,"url":"https://github.com/elastic/kibana/pull/195107","mergeCommit":{"message":"[Synthetics] Fix ping heatmap payload (#195107)\n\n## Summary\r\n\r\nWe addressed #180076 recently\r\nwith these two PRs:\r\n\r\n- https://github.com/elastic/kibana/pull/184177\r\n- https://github.com/elastic/kibana/pull/192508\r\n\r\nWe were seeing a strange error that was difficult to repro, so we put in\r\na best-effort patch that was still ineffective. The reason this issue\r\nhappens is because in the code it's possible to divide by 0, which\r\nyields a value of `Infinity`, which at some point causes our interval\r\nvalue supplied to the server route to be an empty string.\r\n\r\nThis patch will make it so that we never pass a value of 0 to be used in\r\nthe calculation of bucket sizes in this hook.","sha":"560d561e21fe51020954bd9e3246f238ffa026ba"}},"sourceBranch":"main","suggestedTargetBranches":["8.x","8.15"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195107","number":195107,"mergeCommit":{"message":"[Synthetics] Fix ping heatmap payload (#195107)\n\n## Summary\r\n\r\nWe addressed #180076 recently\r\nwith these two PRs:\r\n\r\n- https://github.com/elastic/kibana/pull/184177\r\n- https://github.com/elastic/kibana/pull/192508\r\n\r\nWe were seeing a strange error that was difficult to repro, so we put in\r\na best-effort patch that was still ineffective. The reason this issue\r\nhappens is because in the code it's possible to divide by 0, which\r\nyields a value of `Infinity`, which at some point causes our interval\r\nvalue supplied to the server route to be an empty string.\r\n\r\nThis patch will make it so that we never pass a value of 0 to be used in\r\nthe calculation of bucket sizes in this hook.","sha":"560d561e21fe51020954bd9e3246f238ffa026ba"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.15","label":"v8.15.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Justin Kambic <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We addressed #180076 recently with these two PRs:
We were seeing a strange error that was difficult to repro, so we put in a best-effort patch that was still ineffective. The reason this issue happens is because in the code it's possible to divide by 0, which yields a value of
Infinity, which at some point causes our interval value supplied to the server route to be an empty string.This patch will make it so that we never pass a value of 0 to be used in the calculation of bucket sizes in this hook.