Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dev docs] Add recently viewed docs #195001
[dev docs] Add recently viewed docs #195001
Changes from 7 commits
0baf941
a340d2a
c579d26
ecf5d29
75dde30
2e8b36c
2b6cc19
9d0cb47
e1a7b84
f5a79a5
e4bc1f4
dd3ebe3
5fe27de
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this part, can you explain why
ChromeRecentlyAccessed
is necessary? Is it because it's used in the Left Nav of the Kibana Chrome?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes
ChromeRecentlyAccessed
is a service oncore.chrome.recentlyAccessed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do they scope their items? Extend and access and display within their application? How can they do that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
they create their own instance of RecentlyAccessedService and use it for their own "recently viewed" piece of UI
so:
but also:
this part goes outside of chrome's recently accessed nav and should be better documented in README of that package that we link to