Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Reenable flaky test and add longer timeout #194843

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

criamico
Copy link
Contributor

@criamico criamico commented Oct 3, 2024

Closes #192999

Summary

[Fleet] Reenable skipped flaky test. The beforeEach conditions in this test keep failing because they take longer than the 5s timeout allowed for each test.

Here I'm adding an 8s timeout to attempt fixing it.

Checklist

@criamico criamico added release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.16.0 backport:version Backport to applied version labels labels Oct 3, 2024
@criamico criamico self-assigned this Oct 3, 2024
@criamico criamico marked this pull request as ready for review October 3, 2024 14:03
@criamico criamico requested a review from a team as a code owner October 3, 2024 14:03
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #79 / Controls Dashboard control group apply button range slider selections making selection enables apply button

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @criamico

@criamico criamico added v9.0.0 and removed v8.16.0 labels Oct 3, 2024
@criamico criamico merged commit a7268c4 into elastic:main Oct 3, 2024
31 checks passed
tiansivive pushed a commit to tiansivive/kibana that referenced this pull request Oct 7, 2024
Closes elastic#192999
## Summary

[Fleet] Reenable skipped flaky test. The
[beforeEach](elastic#192999) conditions
in this test keep failing because they take longer than the 5s timeout
allowed for each test.

Here I'm adding an 8s timeout to attempt fixing it.


### Checklist

- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
tiansivive pushed a commit to tiansivive/kibana that referenced this pull request Oct 7, 2024
Closes elastic#192999
## Summary

[Fleet] Reenable skipped flaky test. The
[beforeEach](elastic#192999) conditions
in this test keep failing because they take longer than the 5s timeout
allowed for each test.

Here I'm adding an 8s timeout to attempt fixing it.


### Checklist

- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 194843 locally

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 7, 2024
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 194843 locally

@criamico criamico added backport:skip This commit does not require backporting and removed backport:version Backport to applied version labels labels Oct 9, 2024
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v9.0.0
Projects
None yet
5 participants