[Cloud Security] Render Setup Technology Selector based on deployment mode #194347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
4 tasks
seanrathier
added
Team:Cloud Security
|
Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security) |
seanrathier
added
the
release_note:skip
jen-huang
approved these changes
Oct 1, 2024
botelastic
bot
added
the
Team:Fleet
|
Pinging @elastic/fleet (Team:Fleet) |
💔 Build FailedFailed CI Steps
Test Failures
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @seanrathier |
seanrathier
force-pushed
the
191041-render-setup-technology-deployment-mode
branch
from
1b7ae28
to
37f5619
Compare
Omolola-Akinleye
approved these changes
Oct 7, 2024
|
/ci |
seanrathier
force-pushed
the
191041-render-setup-technology-deployment-mode
branch
from
21871f3
to
0fe3408
Compare
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
cc @seanrathier |
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11255360120 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 9, 2024
… mode (elastic#194347) (cherry picked from commit 2609a53)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
2 tasks
kibanamachine
added a commit
that referenced
this pull request
Oct 9, 2024
…oyment mode (#194347) (#195591) # Backport This will backport the following commits from `main` to `8.x`: - [[Cloud Security] Render Setup Technology Selector based on deployment mode (#194347)](#194347) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"seanrathier","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-09T12:52:03Z","message":"[Cloud Security] Render Setup Technology Selector based on deployment mode (#194347)","sha":"2609a533fa950b9e7974d704fa0c3f9986816dbe","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v9.0.0","Team:Cloud Security","backport:prev-minor","ci:cloud-deploy","8.16 candidate"],"title":"[Cloud Security] Render Setup Technology Selector based on deployment mode","number":194347,"url":"https://github.com/elastic/kibana/pull/194347","mergeCommit":{"message":"[Cloud Security] Render Setup Technology Selector based on deployment mode (#194347)","sha":"2609a533fa950b9e7974d704fa0c3f9986816dbe"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/194347","number":194347,"mergeCommit":{"message":"[Cloud Security] Render Setup Technology Selector based on deployment mode (#194347)","sha":"2609a533fa950b9e7974d704fa0c3f9986816dbe"}}]}] BACKPORT--> Co-authored-by: seanrathier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change migrates the CSPM agentless setup to use the deployment_mode setting in the CSPM integration.
It also fixes
I discovered an issue with how we are converting to use the
deployment_modes, currently Fleet checks if ANY integration has thedeployment_mode agentlessset to determine if agentless is available. However, we have KSPM and CNVM which is not agentless.Issue created here to determine the best solution for all agentless integrations here
Related PRs
Checklist