Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[workflows] Add condition to if backport:skip event #194158

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

jbudz
Copy link
Member

@jbudz jbudz commented Sep 26, 2024

To only run when the label is removed and a backport:* label exists.

The on-merge workflow has historically supported version labels without
the existence of backport labels when a pull request is closed.
This isn't an expected use case now that we've enforced the label check,
but it still is possible to trigger.

Testing

  1. Merge pull request
  2. Add v8.16.0 , backport:skip labels
  3. Remove backport:skip label (current trigger 1)
  4. Add backport:prev-minor label (current trigger 2)

Should trigger the action once via step 4.

This PR is split into two commits, the first with the condition and the
second with the changes run through a formatter.

To only run when the label is removed and a backport:* label exists.

The on-merge workflow has historically supported version labels without
the existence of backport labels when a pull request is closed.
This isn't an expected use case now that we've enforced the label check,
but it still is possible to trigger.

Testing

1) Merge pull request
2) Add v8.16.0 label
3) Remove backport:skip label (current trigger 1)
4) Add backport:prev-minor label (current trigger 2)

Should trigger the action once.

This PR is split into two commits, the first with the condition and the
second with the changes run through a formatter.
@jbudz jbudz added Team:Operations Team label for Operations Team release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting labels Sep 26, 2024
@jbudz jbudz requested a review from a team as a code owner September 26, 2024 14:19
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@jbudz jbudz added the v8.16.0 label Sep 26, 2024
@jbudz jbudz merged commit 97d9ab2 into elastic:main Sep 26, 2024
15 checks passed
jbudz added a commit that referenced this pull request Sep 26, 2024
jbudz added a commit to jbudz/kibana that referenced this pull request Sep 26, 2024
jbudz added a commit that referenced this pull request Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v8.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants