[React@18] Upgrade @types to React 18 #194144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dosant
added
release_note:skip
|
Pinging @elastic/appex-sharedux (Team:SharedUX) |
JordanSh
approved these changes
Sep 30, 2024
tomsonpl
approved these changes
Sep 30, 2024
jloleysens
approved these changes
Sep 30, 2024
nreese
approved these changes
Sep 30, 2024
packages/kbn-expandable-flyout/src/components/resizable_container.tsx
Outdated
Show resolved
Hide resolved
PhilippeOberti
approved these changes
Sep 30, 2024
sphilipse
approved these changes
Oct 1, 2024
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Any counts in public APIs
Async chunks
History
To update your PR or re-run it, just comment with: |
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11122738411 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 1, 2024
## Summary Part of elastic#138222 This PR finilizes the breaking type fixes that are needed for upgrade to React@18. Most of the remaining issues are muted with "@ts-expect-error" are tricky or could be runtime bugs that need to be looked at. **Since the types changes are backward compatible (except the new APIs) we can upgrade to @types/react@18 now so that we "save" the progress and all the code in Kibana from now on is written in compatbile for react@18 way from types perspective.** (cherry picked from commit bdd57b6)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 1, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [[React@18] Upgrade @types to React 18 (#194144)](#194144) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Anton Dosov","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-01T09:40:11Z","message":"[React@18] Upgrade @types to React 18 (#194144)\n\n## Summary\r\n\r\nPart of https://github.com/elastic/kibana/issues/138222\r\n\r\nThis PR finilizes the breaking type fixes that are needed for upgrade to\r\nReact@18.\r\nMost of the remaining issues are muted with \"@ts-expect-error\" are\r\ntricky or could be runtime bugs that need to be looked at.\r\n\r\n**Since the types changes are backward compatible (except the new APIs)\r\nwe can upgrade to @types/react@18 now so that we \"save\" the progress and\r\nall the code in Kibana from now on is written in compatbile for react@18\r\nway from types perspective.**","sha":"bdd57b64fe19683c481f673d6f1571f91379e730","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v9.0.0","Team:SharedUX","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-infra_services","Team:obs-ux-management","apm:review"],"title":"[React@18] Upgrade @types to React 18","number":194144,"url":"https://github.com/elastic/kibana/pull/194144","mergeCommit":{"message":"[React@18] Upgrade @types to React 18 (#194144)\n\n## Summary\r\n\r\nPart of https://github.com/elastic/kibana/issues/138222\r\n\r\nThis PR finilizes the breaking type fixes that are needed for upgrade to\r\nReact@18.\r\nMost of the remaining issues are muted with \"@ts-expect-error\" are\r\ntricky or could be runtime bugs that need to be looked at.\r\n\r\n**Since the types changes are backward compatible (except the new APIs)\r\nwe can upgrade to @types/react@18 now so that we \"save\" the progress and\r\nall the code in Kibana from now on is written in compatbile for react@18\r\nway from types perspective.**","sha":"bdd57b64fe19683c481f673d6f1571f91379e730"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/194144","number":194144,"mergeCommit":{"message":"[React@18] Upgrade @types to React 18 (#194144)\n\n## Summary\r\n\r\nPart of https://github.com/elastic/kibana/issues/138222\r\n\r\nThis PR finilizes the breaking type fixes that are needed for upgrade to\r\nReact@18.\r\nMost of the remaining issues are muted with \"@ts-expect-error\" are\r\ntricky or could be runtime bugs that need to be looked at.\r\n\r\n**Since the types changes are backward compatible (except the new APIs)\r\nwe can upgrade to @types/react@18 now so that we \"save\" the progress and\r\nall the code in Kibana from now on is written in compatbile for react@18\r\nway from types perspective.**","sha":"bdd57b64fe19683c481f673d6f1571f91379e730"}}]}] BACKPORT--> Co-authored-by: Anton Dosov <[email protected]>
delanni
added a commit
that referenced
this pull request
Oct 2, 2024
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #138222
This PR finilizes the breaking type fixes that are needed for upgrade to React@18.
Most of the remaining issues are muted with "@ts-expect-error" are tricky or could be runtime bugs that need to be looked at.
Since the types changes are backward compatible (except the new APIs) we can upgrade to @types/react@18 now so that we "save" the progress and all the code in Kibana from now on is written in compatbile for react@18 way from types perspective.