[RCA] Fix extra margin on navigation menu #194142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benakansara
added
release_note:skip
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
botelastic
bot
added
the
ci:project-deploy-observability
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
To update your PR or re-run it, just comment with: cc @benakansara |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 26, 2024
Resolves elastic#194146 Removes extra margin on top of left navigation menu https://github.com/user-attachments/assets/bdcbac02-dff6-4824-8f15-020eb45b3d1f (cherry picked from commit 4323814)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Sep 26, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [[RCA] Fix extra margin on navigation menu (#194142)](#194142) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Bena Kansara","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-26T14:57:02Z","message":"[RCA] Fix extra margin on navigation menu (#194142)\n\nResolves https://github.com/elastic/kibana/issues/194146\r\n\r\nRemoves extra margin on top of left navigation menu\r\n\r\n\r\nhttps://github.com/user-attachments/assets/bdcbac02-dff6-4824-8f15-020eb45b3d1f","sha":"4323814d48546983f632a8f67b012d30ded737e8","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","ci:project-deploy-observability","Team:obs-ux-management","v8.16.0","backport:version"],"title":"[RCA] Fix extra margin on navigation menu","number":194142,"url":"https://github.com/elastic/kibana/pull/194142","mergeCommit":{"message":"[RCA] Fix extra margin on navigation menu (#194142)\n\nResolves https://github.com/elastic/kibana/issues/194146\r\n\r\nRemoves extra margin on top of left navigation menu\r\n\r\n\r\nhttps://github.com/user-attachments/assets/bdcbac02-dff6-4824-8f15-020eb45b3d1f","sha":"4323814d48546983f632a8f67b012d30ded737e8"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/194142","number":194142,"mergeCommit":{"message":"[RCA] Fix extra margin on navigation menu (#194142)\n\nResolves https://github.com/elastic/kibana/issues/194146\r\n\r\nRemoves extra margin on top of left navigation menu\r\n\r\n\r\nhttps://github.com/user-attachments/assets/bdcbac02-dff6-4824-8f15-020eb45b3d1f","sha":"4323814d48546983f632a8f67b012d30ded737e8"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Bena Kansara <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #194146
Removes extra margin on top of left navigation menu
Screen.Recording.2024-09-25.at.21.44.35.mov