Update Search Index Document Card design. #194061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efegurkan
added
release_note:skip
…ndex-document-card-design
…:efegurkan/kibana into update-search-index-document-card-design
…ndex-document-card-design
joemcelroy
reviewed
Sep 27, 2024
| @@ -53,6 +57,10 @@ export const DocumentList: React.FC<DocumentListProps> = ({ | |||
| meta, | |||
| onPaginate, | |||
| setDocsPerPage, | |||
| defaultVisibleFields = 3, | |||
There was a problem hiding this comment.
suggestion - have a resultProps prop which passes down these to the Result component?
joemcelroy
approved these changes
Sep 27, 2024
joemcelroy
reviewed
Sep 27, 2024
| @@ -305,4 +305,47 @@ export function defineRoutes({ | |||
| } | |||
| }) | |||
| ); | |||
| router.post( | |||
There was a problem hiding this comment.
suggestion: we could rely on the index management APIs here for getting index mappings instead.
There was a problem hiding this comment.
For the cases where we need multiple index responses, index management api returns 500. i.e. 'index1,index2' where we expect a response like
{
index1: ...,
index2: ...,
}
Therefore I will stick with current implementation for this PR but definitely I am open to change it later.
joemcelroy
reviewed
Sep 27, 2024
| color="subdued" | ||
| grow | ||
| css={css` | ||
| //width: ${euiTheme.base * 4}px; |
There was a problem hiding this comment.
this suppose to be commented out?
There was a problem hiding this comment.
This was supposed to go away :D it is not even correct syntax
…ndex-document-card-design
|
also double check your labels, I suggest to add |
efegurkan
added
backport:prev-minor
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Module Count
Public APIs missing comments
Async chunks
Public APIs missing exports
Page load bundle
History
To update your PR or re-run it, just comment with: |
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11124391591 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 1, 2024
## Summary https://github.com/user-attachments/assets/552e1198-ba95-45d6-b13b-e1b26060d34c This PR adds an option to add a richer design for Result card. Defaults still stay the same with old design. Screenshot from Index Management. <img width="1139" alt="Screenshot 2024-09-27 at 14 52 25" src="https://github.com/user-attachments/assets/754a22c5-c3db-4385-b1ad-4e93a8615b9c"> Added a bunch of options to show score, show amount of fields to show when collapsed by default etc. ### Checklist Delete any items that are not applicable to this PR. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [x] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [x] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [x] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit 5bc33cd)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
This was referenced Oct 2, 2024
kibanamachine
added a commit
that referenced
this pull request
Oct 2, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [Update Search Index Document Card design. (#194061)](#194061) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Efe Gürkan YALAMAN","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-01T11:29:31Z","message":"Update Search Index Document Card design. (#194061)\n\n## Summary\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/552e1198-ba95-45d6-b13b-e1b26060d34c\r\n\r\nThis PR adds an option to add a richer design for Result card. \r\nDefaults still stay the same with old design.\r\nScreenshot from Index Management.\r\n<img width=\"1139\" alt=\"Screenshot 2024-09-27 at 14 52 25\"\r\nsrc=\"https://github.com/user-attachments/assets/754a22c5-c3db-4385-b1ad-4e93a8615b9c\">\r\n\r\nAdded a bunch of options to show score, show amount of fields to show\r\nwhen collapsed by default etc.\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [ ]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n- [x] Any UI touched in this PR is usable by keyboard only (learn more\r\nabout [keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n- [x] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n- [x] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [x] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"5bc33cd69eeb828d519ca44b8a3c3ba35c306e19","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","v8.16.0"],"title":"Update Search Index Document Card design.","number":194061,"url":"https://github.com/elastic/kibana/pull/194061","mergeCommit":{"message":"Update Search Index Document Card design. (#194061)\n\n## Summary\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/552e1198-ba95-45d6-b13b-e1b26060d34c\r\n\r\nThis PR adds an option to add a richer design for Result card. \r\nDefaults still stay the same with old design.\r\nScreenshot from Index Management.\r\n<img width=\"1139\" alt=\"Screenshot 2024-09-27 at 14 52 25\"\r\nsrc=\"https://github.com/user-attachments/assets/754a22c5-c3db-4385-b1ad-4e93a8615b9c\">\r\n\r\nAdded a bunch of options to show score, show amount of fields to show\r\nwhen collapsed by default etc.\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [ ]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n- [x] Any UI touched in this PR is usable by keyboard only (learn more\r\nabout [keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n- [x] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n- [x] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [x] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"5bc33cd69eeb828d519ca44b8a3c3ba35c306e19"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/194061","number":194061,"mergeCommit":{"message":"Update Search Index Document Card design. (#194061)\n\n## Summary\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/552e1198-ba95-45d6-b13b-e1b26060d34c\r\n\r\nThis PR adds an option to add a richer design for Result card. \r\nDefaults still stay the same with old design.\r\nScreenshot from Index Management.\r\n<img width=\"1139\" alt=\"Screenshot 2024-09-27 at 14 52 25\"\r\nsrc=\"https://github.com/user-attachments/assets/754a22c5-c3db-4385-b1ad-4e93a8615b9c\">\r\n\r\nAdded a bunch of options to show score, show amount of fields to show\r\nwhen collapsed by default etc.\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [ ]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n- [x] Any UI touched in this PR is usable by keyboard only (learn more\r\nabout [keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n- [x] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n- [x] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [x] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"5bc33cd69eeb828d519ca44b8a3c3ba35c306e19"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Efe Gürkan YALAMAN <[email protected]> Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Alex Szabo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Screen.Recording.2024-09-27.at.14.45.52.mov
This PR adds an option to add a richer design for Result card.
Defaults still stay the same with old design.
Screenshot from Index Management.
Added a bunch of options to show score, show amount of fields to show when collapsed by default etc.
Checklist
Delete any items that are not applicable to this PR.