[Security Solution] Support for kibana spaces in openapi generated securitySolutionApi service for integration tests #194029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiansivive
added
release_note:skip
tiansivive
force-pushed
the
add-spaces-support-openapi-gen
branch
from
09f61a6 to
16be27f
Compare
tiansivive
force-pushed
the
add-spaces-support-openapi-gen
branch
from
16be27f to
8f41920
Compare
maximpn
approved these changes
Sep 25, 2024
| @@ -29,9 +31,9 @@ export function SecuritySolutionApiProvider({ getService }: FtrProviderContext) | |||
| * {{{description}}} | |||
| */ | |||
| {{/if}} | |||
| {{camelCase operationId}}({{#if (or requestQuery requestParams requestBody)}}props: {{operationId}}Props{{/if}}) { | |||
| {{camelCase operationId}}({{#if (or requestQuery requestParams requestBody)}}props: {{operationId}}Props, {{/if}}kibanaSpace: string = 'default') { | |||
There was a problem hiding this comment.
nit: TS is able to infer string type from the literal. It's enough to define kibanaSpace = 'default'.
💛 Build succeeded, but was flaky
Failed CI StepsTest FailuresMetrics [docs]
History
To update your PR or re-run it, just comment with: cc @maximpn |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
2 tasks
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
tiansivive
added a commit
to tiansivive/kibana
that referenced
this pull request
Sep 30, 2024
…curitySolutionApi service for integration tests (elastic#194029) ### Summary This PR adds support for Kibana Spaces in the generated `securitySolutionApi` service for integration tests. Users can now pass an extra parameter `kibanaSpace` when calling a route from the service. The provided space will be prefixed to the API's path. If no argument is provided, it is default'ed to `'default'` --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit 2f45c90) # Conflicts: # x-pack/test/api_integration/services/security_solution_api.gen.ts # x-pack/test/api_integration/services/security_solution_endpoint_exceptions_api.gen.ts # x-pack/test/api_integration/services/security_solution_exceptions_api.gen.ts # x-pack/test/api_integration/services/security_solution_lists_api.gen.ts
tiansivive
added a commit
that referenced
this pull request
Sep 30, 2024
…ted securitySolutionApi service for integration tests (#194029) (#194400) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Solution] Support for kibana spaces in openapi generated securitySolutionApi service for integration tests (#194029)](#194029) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Tiago Vila Verde","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-26T17:53:25Z","message":"[Security Solution] Support for kibana spaces in openapi generated securitySolutionApi service for integration tests (#194029)\n\n### Summary\r\n\r\nThis PR adds support for Kibana Spaces in the generated\r\n`securitySolutionApi` service for integration tests.\r\n\r\nUsers can now pass an extra parameter `kibanaSpace` when calling a route\r\nfrom the service. The provided space will be prefixed to the API's path.\r\nIf no argument is provided, it is default'ed to `'default'`\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"2f45c90d2f58e9f0e3b5ff90f7cbece482478c00","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","v8.16.0"],"number":194029,"url":"https://github.com/elastic/kibana/pull/194029","mergeCommit":{"message":"[Security Solution] Support for kibana spaces in openapi generated securitySolutionApi service for integration tests (#194029)\n\n### Summary\r\n\r\nThis PR adds support for Kibana Spaces in the generated\r\n`securitySolutionApi` service for integration tests.\r\n\r\nUsers can now pass an extra parameter `kibanaSpace` when calling a route\r\nfrom the service. The provided space will be prefixed to the API's path.\r\nIf no argument is provided, it is default'ed to `'default'`\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"2f45c90d2f58e9f0e3b5ff90f7cbece482478c00"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/194029","number":194029,"mergeCommit":{"message":"[Security Solution] Support for kibana spaces in openapi generated securitySolutionApi service for integration tests (#194029)\n\n### Summary\r\n\r\nThis PR adds support for Kibana Spaces in the generated\r\n`securitySolutionApi` service for integration tests.\r\n\r\nUsers can now pass an extra parameter `kibanaSpace` when calling a route\r\nfrom the service. The provided space will be prefixed to the API's path.\r\nIf no argument is provided, it is default'ed to `'default'`\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"2f45c90d2f58e9f0e3b5ff90f7cbece482478c00"}},{"branch":"8.x","label":"v8.16.0","labelRegex":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> --------- Co-authored-by: kibanamachine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for Kibana Spaces in the generated
securitySolutionApiservice for integration tests.Users can now pass an extra parameter
kibanaSpacewhen calling a route from the service. The provided space will be prefixed to the API's path. If no argument is provided, it is default'ed to'default'