[Spaces and Roles] Updates for finalized contents and UX #193923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsullivan
commented
Sep 24, 2024
| @@ -404,7 +402,7 @@ export class FeatureTable extends Component<Props, State> { | |||
| 'xpack.security.management.editRole.featureTable.managementCategoryHelpText', | |||
| { | |||
| defaultMessage: | |||
| 'Access to Stack Management is determined by both Elasticsearch and Kibana privileges, and cannot be explicitly disabled.', | |||
| 'Additional Stack Management permissions can be found outside of this menu, in index and cluster privileges.', | |||
tsullivan
commented
Sep 24, 2024
| </h3> | ||
| </EuiFlexItem> | ||
| <EuiFlexItem> | ||
| <EuiBetaBadge |
There was a problem hiding this comment.
If solution view is set:
If classic view is set:
tsullivan
force-pushed
the
spaces/assign-roles-to-space-content-update
branch
from
e80af03 to
36a4e10
Compare
tsullivan
commented
Sep 24, 2024
| size="s" | ||
| iconType="iInCircle" | ||
| title={i18n.translate( | ||
| 'xpack.spaces.management.manageSpacePage.solutionViewSelect.classicDefaultViewCallout', |
tsullivan
added
release_note:skip
tsullivan
force-pushed
the
spaces/assign-roles-to-space-content-update
branch
from
2c89ba8 to
46f10a2
Compare
|
Pinging @elastic/kibana-security (Team:Security) |
elena-shostak
approved these changes
Sep 27, 2024
Comment on lines
160
to
163
| ? space.solution | ||
| : showClassicDefaultViewCallout | ||
| ? SOLUTION_VIEW_CLASSIC | ||
| : undefined |
There was a problem hiding this comment.
Nit, maybe simplify nested ternary?
space.solution ?? (showClassicDefaultViewCallout ? SOLUTION_VIEW_CLASSIC : undefined)
8 tasks
@elena-shostak good catch! I see what you mean. It looks like the |
|
@elena-shostak even though you have already approved, would you like to take another look? I manually resolved some merge conflicts, and fixed the issue with the text jumping around in the Solution View picker. |
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
LGTM! Thanks |
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11132050996 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 1, 2024
) ## Summary Follows elastic#191795 * Minor content updates to Spaces Management * [spaces grid] More space for "description" column in Spaces Grid * [create space and edit space] Add "New" badge to Solution View picker * [create space and edit space] Move avatar section down * [create space] Remove the edit/update functionality from the Create Space page * [create space] Only show the Feature Visibility section if the selected solution is `classic` * [edit space] Rearrange the footer icons in the General tab * [edit space] Show callout when classic is selected by default * [edit space] Update the action icons shown on hover on the Assigned Roles table ### Checklist Delete any items that are not applicable to this PR. - [X] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [X] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [X] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) (cherry picked from commit 3f90156)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 1, 2024
…) (#194637) # Backport This will backport the following commits from `main` to `8.x`: - [[Spaces and Roles] Updates for finalized contents and UX (#193923)](#193923) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Tim Sullivan","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-01T19:22:29Z","message":"[Spaces and Roles] Updates for finalized contents and UX (#193923)\n\n## Summary\r\n\r\nFollows https://github.com/elastic/kibana/pull/191795\r\n\r\n* Minor content updates to Spaces Management\r\n* [spaces grid] More space for \"description\" column in Spaces Grid\r\n* [create space and edit space] Add \"New\" badge to Solution View picker\r\n* [create space and edit space] Move avatar section down\r\n* [create space] Remove the edit/update functionality from the Create\r\nSpace page\r\n* [create space] Only show the Feature Visibility section if the\r\nselected solution is `classic`\r\n* [edit space] Rearrange the footer icons in the General tab\r\n* [edit space] Show callout when classic is selected by default\r\n* [edit space] Update the action icons shown on hover on the Assigned\r\nRoles table\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [X] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [ ]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [X] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [X] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)","sha":"3f901562cffd9b8d7ff4f4e872c4e7ccf8575719","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Security","release_note:skip","v9.0.0","v8.16.0","8.17 candidate","backport:version"],"title":"[Spaces and Roles] Updates for finalized contents and UX","number":193923,"url":"https://github.com/elastic/kibana/pull/193923","mergeCommit":{"message":"[Spaces and Roles] Updates for finalized contents and UX (#193923)\n\n## Summary\r\n\r\nFollows https://github.com/elastic/kibana/pull/191795\r\n\r\n* Minor content updates to Spaces Management\r\n* [spaces grid] More space for \"description\" column in Spaces Grid\r\n* [create space and edit space] Add \"New\" badge to Solution View picker\r\n* [create space and edit space] Move avatar section down\r\n* [create space] Remove the edit/update functionality from the Create\r\nSpace page\r\n* [create space] Only show the Feature Visibility section if the\r\nselected solution is `classic`\r\n* [edit space] Rearrange the footer icons in the General tab\r\n* [edit space] Show callout when classic is selected by default\r\n* [edit space] Update the action icons shown on hover on the Assigned\r\nRoles table\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [X] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [ ]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [X] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [X] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)","sha":"3f901562cffd9b8d7ff4f4e872c4e7ccf8575719"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193923","number":193923,"mergeCommit":{"message":"[Spaces and Roles] Updates for finalized contents and UX (#193923)\n\n## Summary\r\n\r\nFollows https://github.com/elastic/kibana/pull/191795\r\n\r\n* Minor content updates to Spaces Management\r\n* [spaces grid] More space for \"description\" column in Spaces Grid\r\n* [create space and edit space] Add \"New\" badge to Solution View picker\r\n* [create space and edit space] Move avatar section down\r\n* [create space] Remove the edit/update functionality from the Create\r\nSpace page\r\n* [create space] Only show the Feature Visibility section if the\r\nselected solution is `classic`\r\n* [edit space] Rearrange the footer icons in the General tab\r\n* [edit space] Show callout when classic is selected by default\r\n* [edit space] Update the action icons shown on hover on the Assigned\r\nRoles table\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [X] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [ ]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [X] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [X] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)","sha":"3f901562cffd9b8d7ff4f4e872c4e7ccf8575719"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Tim Sullivan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Follows #191795
classicChecklist
Delete any items that are not applicable to this PR.