-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Globally enforce internal API restriction #193792
Changes from all commits
e916f4b
ea02761
7066fa1
e0d4ed8
b2d6a5e
81c58d7
b579951
ff95bde
5fbfb76
4bc36a9
2d73f0b
d02ce7c
d9b3ea9
b42530a
d177cdb
624a65d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -29,6 +29,7 @@ describe('PUT /internal/core/_settings', () => { | |
logging: { | ||
loggers: [{ name: loggerName, level: 'error', appenders: ['console'] }], | ||
}, | ||
server: { restrictInternalApis: false }, | ||
}; | ||
const { startES, startKibana } = createTestServers({ | ||
adjustTimeout: (t: number) => jest.setTimeout(t), | ||
|
@@ -82,6 +83,9 @@ describe('checking all opted-in dynamic config settings', () => { | |
logging: { | ||
loggers: [{ name: 'root', level: 'info', appenders: ['console'] }], | ||
}, | ||
server: { | ||
restrictInternalApis: false, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's less work to disable the restriction in There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should/do we have a task for updating these requests in the future or is the plan to leave them unrestricted in tests? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
The plan is to update requests if and when we need to, which is consistent with the base config for our FTR tests. As for this specific test, |
||
}, | ||
}; | ||
|
||
set(settings, PLUGIN_SYSTEM_ENABLE_ALL_PLUGINS_CONFIG_PATH, true); | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -39,6 +39,7 @@ function createRoot() { | |
}, | ||
], | ||
}, | ||
server: { restrictInternalApis: false }, | ||
}); | ||
} | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -31,6 +31,7 @@ function createRoot(appenderConfig: any) { | |
}, | ||
], | ||
}, | ||
server: { restrictInternalApis: false }, | ||
}); | ||
} | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leaves the restriction disabled for tests consuming
createConfigService
.