[Lens][Datatable] Fix share export and inspect data

.github/CODEOWNERS

@@ -941,6 +941,7 @@ packages/kbn-tinymath @elastic/kibana-visualizations
 packages/kbn-tooling-log @elastic/kibana-operations
 x-pack/plugins/transform @elastic/ml-ui
 x-pack/plugins/translations @elastic/kibana-localization
+packages/kbn-transpose-helpers @elastic/kibana-visualizations
 x-pack/examples/triggers_actions_ui_example @elastic/response-ops
 x-pack/plugins/triggers_actions_ui @elastic/response-ops
 packages/kbn-triggers-actions-ui-types @elastic/response-ops

package.json

@@ -943,6 +943,7 @@
     "@kbn/tinymath": "link:packages/kbn-tinymath",
     "@kbn/transform-plugin": "link:x-pack/plugins/transform",
     "@kbn/translations-plugin": "link:x-pack/plugins/translations",
+    "@kbn/transpose-helpers": "link:packages/kbn-transpose-helpers",
     "@kbn/triggers-actions-ui-example-plugin": "link:x-pack/examples/triggers_actions_ui_example",
     "@kbn/triggers-actions-ui-plugin": "link:x-pack/plugins/triggers_actions_ui",
     "@kbn/triggers-actions-ui-types": "link:packages/kbn-triggers-actions-ui-types",

packages/kbn-transpose-helpers/README.md

@@ -0,0 +1,3 @@
+# @kbn/transpose-helpers
+
+Util functions used convert raw columns into transposed columns.

x-pack/plugins/lens/common/expressions/datatable/transpose_helpers.test.ts → packages/kbn-transpose-helpers/index.test.ts

@@ -1,17 +1,19 @@
 /*
  * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
- * or more contributor license agreements. Licensed under the Elastic License
- * 2.0; you may not use this file except in compliance with the Elastic License
- * 2.0.
+ * or more contributor license agreements. Licensed under the "Elastic License
+ * 2.0", the "GNU Affero General Public License v3.0 only", and the "Server Side
+ * Public License v 1"; you may not use this file except in compliance with, at
+ * your election, the "Elastic License 2.0", the "GNU Affero General Public
+ * License v3.0 only", or the "Server Side Public License, v 1".
  */
 
 import type { FieldFormat } from '@kbn/field-formats-plugin/common';
 import type { Datatable } from '@kbn/expressions-plugin/common';
-import { DatatableArgs } from './datatable';
+import { DatatableArgs } from '@kbn/lens-plugin/common/expressions';
 
-import { transposeTable } from './transpose_helpers';
+import { transposeTable } from '.';
 
-describe('transpose_helpers', () => {
+describe('transpose helpers', () => {
   function buildTable(): Datatable {
     // 3 buckets, 2 metrics
     // first bucket goes A/B/C

x-pack/plugins/lens/common/expressions/datatable/transpose_helpers.ts → packages/kbn-transpose-helpers/index.ts

@@ -1,18 +1,31 @@
 /*
  * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
- * or more contributor license agreements. Licensed under the Elastic License
- * 2.0; you may not use this file except in compliance with the Elastic License
- * 2.0.
+ * or more contributor license agreements. Licensed under the "Elastic License
+ * 2.0", the "GNU Affero General Public License v3.0 only", and the "Server Side
+ * Public License v 1"; you may not use this file except in compliance with, at
+ * your election, the "Elastic License 2.0", the "GNU Affero General Public
+ * License v3.0 only", or the "Server Side Public License, v 1".
  */
 
 import type { Datatable, DatatableColumn, DatatableRow } from '@kbn/expressions-plugin/common';
 import type { FieldFormat } from '@kbn/field-formats-plugin/common';
-import type { DatatableArgs } from './datatable';
-import type { DatatableColumnConfig, DatatableColumnArgs } from './datatable_column';
+import {
+  DatatableArgs,
+  DatatableColumnArgs,
+  DatatableColumnConfig,
+} from '@kbn/lens-plugin/common/expressions';
 
-const TRANSPOSE_SEPARATOR = '---';
+/**
+ * Used to delimitate felids of a transposed column id
+ */
+export const TRANSPOSE_SEPARATOR = '---';
 
-const TRANSPOSE_VISUAL_SEPARATOR = '›';
+/**
+ * Visual deliminator between felids of a transposed column id
+ *
+ * Meant to align with the `MULTI_FIELD_KEY_SEPARATOR` from the data plugin
+ */
+export const TRANSPOSE_VISUAL_SEPARATOR = '›';
 
 export function getTransposeId(value: string, columnId: string) {
   return `${value}${TRANSPOSE_SEPARATOR}${columnId}`;
@@ -34,16 +47,12 @@ export function getOriginalId(id: string) {
  * Transposes the columns of the given table as defined in the arguments.
  * This function modifies the passed in args and firstTable objects.
  * This process consists out of three parts:
+ *
  * * Calculating the new column arguments
  * * Calculating the new datatable columns
  * * Calculating the new rows
  *
- * If the table is tranposed by multiple columns, this process is repeated on top of the previous transformation.
- *
- * @internal
- * @param args Arguments for the table visualization
- * @param firstTable datatable object containing the actual data
- * @param formatters Formatters for all columns to transpose columns by actual display values
+ * If the table is transposed by multiple columns, this process is repeated on top of the previous transformation.
  */
 export function transposeTable(
   args: DatatableArgs,
@@ -52,8 +61,7 @@ export function transposeTable(
 ) {
   args.columns
     .filter((columnArgs) => columnArgs.isTransposed)
-    // start with the inner nested transposed column and work up to preserve column grouping
-    .reverse()
+    .reverse() // start with the inner nested transposed column and work up to preserve column grouping
     .forEach(({ columnId: transposedColumnId }) => {
       const datatableColumnIndex = firstTable.columns.findIndex((c) => c.id === transposedColumnId);
       const datatableColumn = firstTable.columns[datatableColumnIndex];
@@ -86,6 +94,11 @@ export function transposeTable(
         transposedColumnId,
         metricsColumnArgs
       );
+
+      const colOrderMap = new Map(args.columns.map((c, i) => [c.columnId, i]));
+      firstTable.columns.sort((a, b) => {
+        return (colOrderMap.get(a.id) ?? 0) - (colOrderMap.get(b.id) ?? 0);
+      });
     });
 }
 
@@ -131,9 +144,6 @@ function updateColumnArgs(
 
 /**
  * Finds all unique values in a column in order of first occurence
- * @param table Table to search through
- * @param formatter formatter for the column
- * @param columnId column
  */
 function getUniqueValues(table: Datatable, formatter: FieldFormat, columnId: string) {
   const values = new Map<string, unknown>();
@@ -149,9 +159,6 @@ function getUniqueValues(table: Datatable, formatter: FieldFormat, columnId: str
 /**
  * Calculate transposed column objects of the datatable object and puts them into the datatable.
  * Returns args for additional columns grouped by metric
- * @param metricColumns
- * @param firstTable
- * @param uniqueValues
  */
 function transposeColumns(
   args: DatatableArgs,

packages/kbn-transpose-helpers/jest.config.js

@@ -0,0 +1,14 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the "Elastic License
+ * 2.0", the "GNU Affero General Public License v3.0 only", and the "Server Side
+ * Public License v 1"; you may not use this file except in compliance with, at
+ * your election, the "Elastic License 2.0", the "GNU Affero General Public
+ * License v3.0 only", or the "Server Side Public License, v 1".
+ */
+
+module.exports = {
+  preset: '@kbn/test',
+  rootDir: '../..',
+  roots: ['<rootDir>/packages/kbn-transpose-helpers'],
+};

packages/kbn-transpose-helpers/kibana.jsonc

@@ -0,0 +1,5 @@
+{
+  "type": "shared-common",
+  "id": "@kbn/transpose-helpers",
+  "owner": "@elastic/kibana-visualizations"
+}

packages/kbn-transpose-helpers/package.json

@@ -0,0 +1,6 @@
+{
+  "name": "@kbn/transpose-helpers",
+  "private": true,
+  "version": "1.0.0",
+  "license": "Elastic License 2.0 OR AGPL-3.0-only OR SSPL-1.0"
+}

packages/kbn-transpose-helpers/tsconfig.json

@@ -0,0 +1,23 @@
+{
+  "extends": "../../tsconfig.base.json",
+  "compilerOptions": {
+    "outDir": "target/types",
+    "types": [
+      "jest",
+      "node",
+      "react"
+    ]
+  },
+  "include": [
+    "**/*.ts",
+    "**/*.tsx",
+  ],
+  "exclude": [
+    "target/**/*"
+  ],
+  "kbn_references": [
+    "@kbn/field-formats-plugin",
+    "@kbn/expressions-plugin",
+    "@kbn/lens-plugin",
+  ]
+}

src/plugins/chart_expressions/expression_gauge/common/types/expression_functions.ts

@@ -11,6 +11,8 @@ import { $Values } from '@kbn/utility-types';
 import type { PaletteOutput, CustomPaletteParams } from '@kbn/coloring';
 import {
   Datatable,
+  DefaultInspectorAdapters,
+  ExecutionContext,
   ExpressionFunctionDefinition,
   ExpressionValueRender,
 } from '@kbn/expressions-plugin/common';
@@ -86,7 +88,8 @@ export type GaugeExpressionFunctionDefinition = ExpressionFunctionDefinition<
   typeof EXPRESSION_GAUGE_NAME,
   GaugeInput,
   GaugeArguments,
-  ExpressionValueRender<GaugeExpressionProps>
+  ExpressionValueRender<GaugeExpressionProps>,
+  ExecutionContext<DefaultInspectorAdapters>
 >;
 
 export interface Accessors {

src/plugins/chart_expressions/expression_heatmap/common/types/expression_functions.ts

@@ -11,6 +11,8 @@ import { Position } from '@elastic/charts';
 import type { PaletteOutput } from '@kbn/coloring';
 import {
   Datatable,
+  DefaultInspectorAdapters,
+  ExecutionContext,
   ExpressionFunctionDefinition,
   ExpressionValueRender,
 } from '@kbn/expressions-plugin/common';
@@ -114,7 +116,8 @@ export type HeatmapExpressionFunctionDefinition = ExpressionFunctionDefinition<
   typeof EXPRESSION_HEATMAP_NAME,
   HeatmapInput,
   HeatmapArguments,
-  ExpressionValueRender<HeatmapExpressionProps>
+  ExpressionValueRender<HeatmapExpressionProps>,
+  ExecutionContext<DefaultInspectorAdapters>
 >;
 
 export type HeatmapLegendExpressionFunctionDefinition = ExpressionFunctionDefinition<

src/plugins/chart_expressions/expression_heatmap/public/components/helpers.ts

@@ -18,6 +18,7 @@ import {
   DEFAULT_MAX_STOP,
   DEFAULT_MIN_STOP,
 } from '@kbn/coloring';
+import { getOriginalId } from '@kbn/transpose-helpers';
 
 import type { Datatable, DatatableColumn } from '@kbn/expressions-plugin/public';
 import { FormatFactory, IFieldFormat } from '@kbn/field-formats-plugin/common';
@@ -94,11 +95,7 @@ export function getNumericValue(rowValue: number | number[] | undefined) {
   return rowValue;
 }
 
-export const findMinMaxByColumnId = (
-  columnIds: string[],
-  table: Datatable | undefined,
-  getOriginalId: (id: string) => string = getId
-) => {
+export const findMinMaxByColumnId = (columnIds: string[], table: Datatable | undefined) => {
   const minMax: Record<string, { min: number; max: number; fallback?: boolean }> = {};
 
   if (table != null) {

src/plugins/chart_expressions/expression_heatmap/tsconfig.json

@@ -28,6 +28,7 @@
     "@kbn/chart-expressions-common",
     "@kbn/visualization-utils",
     "@kbn/react-kibana-context-render",
+    "@kbn/transpose-helpers",
   ],
   "exclude": [
     "target/**/*",

src/plugins/chart_expressions/expression_legacy_metric/common/types/expression_functions.ts

@@ -10,6 +10,8 @@
 import type { PaletteOutput } from '@kbn/coloring';
 import {
   Datatable,
+  DefaultInspectorAdapters,
+  ExecutionContext,
   ExpressionFunctionDefinition,
   ExpressionValueRender,
   Style,
@@ -47,5 +49,6 @@ export type MetricVisExpressionFunctionDefinition = ExpressionFunctionDefinition
   typeof EXPRESSION_METRIC_NAME,
   MetricInput,
   MetricArguments,
-  ExpressionValueRender<MetricVisRenderConfig>
+  ExpressionValueRender<MetricVisRenderConfig>,
+  ExecutionContext<DefaultInspectorAdapters>
 >;

src/plugins/chart_expressions/expression_metric/common/types/expression_functions.ts

@@ -12,6 +12,8 @@ import { LayoutDirection, MetricStyle, MetricWTrend } from '@elastic/charts';
 import { $Values } from '@kbn/utility-types';
 import {
   Datatable,
+  DefaultInspectorAdapters,
+  ExecutionContext,
   ExpressionFunctionDefinition,
   ExpressionValueRender,
 } from '@kbn/expressions-plugin/common';
@@ -64,7 +66,8 @@ export type MetricVisExpressionFunctionDefinition = ExpressionFunctionDefinition
   typeof EXPRESSION_METRIC_NAME,
   MetricInput,
   MetricArguments,
-  ExpressionValueRender<MetricVisRenderConfig>
+  ExpressionValueRender<MetricVisRenderConfig>,
+  ExecutionContext<DefaultInspectorAdapters>
 >;
 
 export interface TrendlineArguments {

src/plugins/chart_expressions/expression_partition_vis/common/types/expression_functions.ts

@@ -14,6 +14,8 @@ import {
   Datatable,
   ExpressionValueRender,
   ExpressionValueBoxed,
+  DefaultInspectorAdapters,
+  ExecutionContext,
 } from '@kbn/expressions-plugin/common';
 import {
   PARTITION_LABELS_VALUE,
@@ -66,28 +68,32 @@ export type PieVisExpressionFunctionDefinition = ExpressionFunctionDefinition<
   typeof PIE_VIS_EXPRESSION_NAME,
   Datatable,
   PieVisConfig,
-  ExpressionValueRender<PartitionChartProps>
+  ExpressionValueRender<PartitionChartProps>,
+  ExecutionContext<DefaultInspectorAdapters>
 >;
 
 export type TreemapVisExpressionFunctionDefinition = ExpressionFunctionDefinition<
   typeof TREEMAP_VIS_EXPRESSION_NAME,
   Datatable,
   TreemapVisConfig,
-  ExpressionValueRender<PartitionChartProps>
+  ExpressionValueRender<PartitionChartProps>,
+  ExecutionContext<DefaultInspectorAdapters>
 >;
 
 export type MosaicVisExpressionFunctionDefinition = ExpressionFunctionDefinition<
   typeof MOSAIC_VIS_EXPRESSION_NAME,
   Datatable,
   MosaicVisConfig,
-  ExpressionValueRender<PartitionChartProps>
+  ExpressionValueRender<PartitionChartProps>,
+  ExecutionContext<DefaultInspectorAdapters>
 >;
 
 export type WaffleVisExpressionFunctionDefinition = ExpressionFunctionDefinition<
   typeof WAFFLE_VIS_EXPRESSION_NAME,
   Datatable,
   WaffleVisConfig,
-  ExpressionValueRender<PartitionChartProps>
+  ExpressionValueRender<PartitionChartProps>,
+  ExecutionContext<DefaultInspectorAdapters>
 >;
 
 export enum ChartTypes {

src/plugins/chart_expressions/expression_xy/common/types/expression_functions.ts

@@ -13,6 +13,8 @@ import type { PaletteOutput } from '@kbn/coloring';
 import type {
   Datatable,
   DatatableColumnMeta,
+  DefaultInspectorAdapters,
+  ExecutionContext,
   ExpressionFunctionDefinition,
 } from '@kbn/expressions-plugin/common';
 import {
@@ -449,13 +451,15 @@ export type XyVisFn = ExpressionFunctionDefinition<
   typeof XY_VIS,
   Datatable,
   XYArgs,
-  Promise<XYRender>
+  Promise<XYRender>,
+  ExecutionContext<DefaultInspectorAdapters>
 >;
 export type LayeredXyVisFn = ExpressionFunctionDefinition<
   typeof LAYERED_XY_VIS,
   Datatable,
   LayeredXYArgs,
-  Promise<XYRender>
+  Promise<XYRender>,
+  ExecutionContext<DefaultInspectorAdapters>
 >;
 
 export type ExtendedDataLayerFn = ExpressionFunctionDefinition<