[Fleet] Fleet APIs using kbn/config-schema part 3 #193698
Conversation
juliaElastic
added
release_note:skip
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
botelastic
bot
added
the
Team:Fleet
|
Pinging @elastic/fleet (Team:Fleet) |
| !(Array.isArray(assets.elasticsearch?.transform) && assets.elasticsearch?.transform?.length > 0) | ||
| !( | ||
| Array.isArray(assets.elasticsearch?.transform) && | ||
| (assets.elasticsearch?.transform?.length ?? 0) > 0 |
There was a problem hiding this comment.
What's the reason for this change? small bug in the UI?
There was a problem hiding this comment.
made transform optional in TS type as it came up as an error in schema validation (sometimes undefined), and then tsc started complaining about transform?.length possibly undefined
| postNewAgentActionHandlerBuilder: jest.fn(), | ||
| })); | ||
|
|
||
| describe('schema validation', () => { |
There was a problem hiding this comment.
Thanks for all the testing!
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Public APIs missing comments
Async chunks
Public APIs missing exports
History
To update your PR or re-run it, just comment with: |
## Summary Relates elastic#184685 Added response schemas to remaining APIs: - agent_policies - agents, actions - download_source - enrollment_api_key - epm when this is merged, the fleet/openapi folder can be deleted (which includes the previous version of bundled.yaml) ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
Summary
Relates #184685
Added response schemas to remaining APIs:
when this is merged, the fleet/openapi folder can be deleted (which includes the previous version of bundled.yaml)
Checklist