Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Daylight saving time calendar events #193605
[ML] Daylight saving time calendar events #193605
Changes from 22 commits
635bc9f
08712f4
73a7d36
9cf2c1e
18b6985
54ec6b3
2386227
e46008b
47f90ec
8bb0914
143f632
a610b67
8c3c930
c2ce577
a7e4c5d
9f56e20
a68823c
958a4d7
14dd326
5af19ac
0bfc6a8
5c4e367
2d0bb82
4d5ef3a
db72ef0
8b636dc
5b1a167
65a40dc
70fa935
b2ce67e
fea06b1
1a6b4c4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Q: I see that each breadcrumb is implemented this way, so it's not strictly related to the PR, but why aren't we using
locator constants
instead of plain strings?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we probably should be using those here.
I believe these breadcrumb files pre-date the introduction of the locator constants.