Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Obs AI Assistant] Query remote indices by default #193462

Merged
merged 5 commits into from
Nov 22, 2024
Merged

[Obs AI Assistant] Query remote indices by default #193462

merged 5 commits into from
Nov 22, 2024

Conversation

dgieselaar
Copy link
Member

@dgieselaar dgieselaar commented Sep 19, 2024 •
edited by kibanamachine
Loading

Query [ '*', '*:*' ] by default when listing indices.

@dgieselaar dgieselaar added release_note:skip Skip the PR/issue when compiling release notes v8.16.0 labels Sep 19, 2024
@dgieselaar dgieselaar self-assigned this Sep 19, 2024
@dgieselaar dgieselaar requested a review from a team as a code owner September 19, 2024 17:48
@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:Obs AI Assistant Observability AI Assistant labels Sep 19, 2024
@obltmachine
Copy link

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

neptunian
neptunian reviewed Sep 19, 2024
View reviewed changes
...observability_solution/observability_ai_assistant/server/functions/get_dataset_info/index.ts
@@ -48,7 +48,7 @@ export function registerGetDatasetInfoFunction({

try {
const body = await esClient.asCurrentUser.indices.resolveIndex({
name: index === '' ? '*' : index.split(','),
name: index === '' ? ['*', '*:*'] : index.split(','),
Copy link
Contributor

@neptunian neptunian Sep 19, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this only query remote indices if index is not specified? Is that the goal or to always query remote clusters?

I'll mention we've had issues querying * remote clusters in the past with users wanting to specify which remote clusters because it can take a long time if there are many remotes. Perhaps we can have this as a setting at some point.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this only query remote indices if index is not specified? Is that the goal or to always query remote clusters?

the former yes

I'll mention we've had issues querying * remote clusters in the past with users wanting to specify which remote clusters because it can take a long time if there are many remotes. Perhaps we can have this as a setting at some point.

This only lists the indices, and then the assistant can pick one for querying, so I think that's usually fine. Agreed a setting would be nice (but also a little wary of having too many settings).

@dgieselaar
Copy link
Member Author

@elasticmachine merge upstream

@dgieselaar dgieselaar added v9.0.0 backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) backport:current-major Backport to all previous minor branches labels Oct 4, 2024
@kibana-ci
Copy link
Collaborator

kibana-ci commented Oct 4, 2024 •
edited
Loading

💛 Build succeeded, but was flaky

  • Buildkite Build
  • Commit: 59af58b
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-193462-59af58bf17b1

Failed CI Steps

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @dgieselaar

@dgieselaar
Copy link
Member Author

@elasticmachine merge upstream

@dgieselaar dgieselaar enabled auto-merge (squash) October 9, 2024 16:18
@dgieselaar
Copy link
Member Author

@elasticmachine merge upstream

@dgieselaar
Copy link
Member Author

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

elasticmachine commented Nov 22, 2024 •
edited
Loading

💚 Build Succeeded

  • Buildkite Build
  • Commit: 8297f49
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-193462-8297f4904f5f

Metrics [docs]

✅ unchanged

History

cc @dgieselaar

@dgieselaar dgieselaar merged commit ae31ce1 into elastic:main Nov 22, 2024
25 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.17, 8.x

https://github.com/elastic/kibana/actions/runs/11974468802

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 22, 2024
@dgieselaar
[Obs AI Assistant] Query remote indices by default (elastic#193462)
bc395dd 
Query `[ '*', '*:*' ]` by default when listing indices.

Co-authored-by: Elastic Machine <[email protected]>
(cherry picked from commit ae31ce1)
@kibanamachine kibanamachine mentioned this pull request Nov 22, 2024
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 22, 2024
@dgieselaar
[Obs AI Assistant] Query remote indices by default (elastic#193462)
a313dc3 
Query `[ '*', '*:*' ]` by default when listing indices.

Co-authored-by: Elastic Machine <[email protected]>
(cherry picked from commit ae31ce1)
@kibanamachine kibanamachine mentioned this pull request Nov 22, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.17
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

This was referenced Nov 22, 2024
Merged
Merged
Merged
kibanamachine added a commit that referenced this pull request Nov 22, 2024
@kibanamachine @dgieselaar
[8.x] [Obs AI Assistant] Query remote indices by default (#193462) (#…
687013c 
…201399)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Obs AI Assistant] Query remote indices by default
(#193462)](#193462)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Dario
Gieselaar","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-22T14:27:16Z","message":"[Obs
AI Assistant] Query remote indices by default (#193462)\n\nQuery `[ '*',
'*:*' ]` by default when listing indices.\r\n\r\nCo-authored-by: Elastic
Machine
<[email protected]>","sha":"ae31ce1ea6b69444714e86de1aea0a6fee79e130","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","Team:Obs
AI
Assistant","ci:project-deploy-observability","backport:current-major","v8.17.0"],"title":"[Obs
AI Assistant] Query remote indices by
default","number":193462,"url":"https://github.com/elastic/kibana/pull/193462","mergeCommit":{"message":"[Obs
AI Assistant] Query remote indices by default (#193462)\n\nQuery `[ '*',
'*:*' ]` by default when listing indices.\r\n\r\nCo-authored-by: Elastic
Machine
<[email protected]>","sha":"ae31ce1ea6b69444714e86de1aea0a6fee79e130"}},"sourceBranch":"main","suggestedTargetBranches":["8.17"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193462","number":193462,"mergeCommit":{"message":"[Obs
AI Assistant] Query remote indices by default (#193462)\n\nQuery `[ '*',
'*:*' ]` by default when listing indices.\r\n\r\nCo-authored-by: Elastic
Machine
<[email protected]>","sha":"ae31ce1ea6b69444714e86de1aea0a6fee79e130"}},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Dario Gieselaar <[email protected]>
kibanamachine added a commit that referenced this pull request Nov 22, 2024
@kibanamachine @dgieselaar
[8.17] [Obs AI Assistant] Query remote indices by default (#193462) (#…
25884bd 
…201398)

# Backport

This will backport the following commits from `main` to `8.17`:
- [[Obs AI Assistant] Query remote indices by default
(#193462)](#193462)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Dario
Gieselaar","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-22T14:27:16Z","message":"[Obs
AI Assistant] Query remote indices by default (#193462)\n\nQuery `[ '*',
'*:*' ]` by default when listing indices.\r\n\r\nCo-authored-by: Elastic
Machine
<[email protected]>","sha":"ae31ce1ea6b69444714e86de1aea0a6fee79e130","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","Team:Obs
AI
Assistant","ci:project-deploy-observability","backport:current-major","v8.17.0"],"title":"[Obs
AI Assistant] Query remote indices by
default","number":193462,"url":"https://github.com/elastic/kibana/pull/193462","mergeCommit":{"message":"[Obs
AI Assistant] Query remote indices by default (#193462)\n\nQuery `[ '*',
'*:*' ]` by default when listing indices.\r\n\r\nCo-authored-by: Elastic
Machine
<[email protected]>","sha":"ae31ce1ea6b69444714e86de1aea0a6fee79e130"}},"sourceBranch":"main","suggestedTargetBranches":["8.17"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193462","number":193462,"mergeCommit":{"message":"[Obs
AI Assistant] Query remote indices by default (#193462)\n\nQuery `[ '*',
'*:*' ]` by default when listing indices.\r\n\r\nCo-authored-by: Elastic
Machine
<[email protected]>","sha":"ae31ce1ea6b69444714e86de1aea0a6fee79e130"}},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Dario Gieselaar <[email protected]>
paulinashakirova pushed a commit to paulinashakirova/kibana that referenced this pull request Nov 26, 2024
@dgieselaar @elasticmachine @paulinashakirova
[Obs AI Assistant] Query remote indices by default (elastic#193462)
3a4c091 
Query `[ '*', '*:*' ]` by default when listing indices.

Co-authored-by: Elastic Machine <[email protected]>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
@dgieselaar @elasticmachine @CAWilson94
[Obs AI Assistant] Query remote indices by default (elastic#193462)
fe1f234 
Query `[ '*', '*:*' ]` by default when listing indices.

Co-authored-by: Elastic Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neptunian neptunian neptunian left review comments

@sorenlouv sorenlouv sorenlouv approved these changes

Assignees

@dgieselaar dgieselaar

Labels
backport:current-major Backport to all previous minor branches backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:Obs AI Assistant Observability AI Assistant v8.17.0 v8.18.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@dgieselaar @obltmachine @kibana-ci @elasticmachine @kibanamachine @sorenlouv @neptunian