[Embeddable Rebuild] [Controls] Remove react_controls top-level folder
#193451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Heenawter
added
Team:Presentation
Heenawter
force-pushed
the
embeddableRebuild_controls-folder-restructure_2024-09-19
branch
from
7c002ff to
b0e0dff
Compare
Heenawter
force-pushed
the
embeddableRebuild_controls-folder-restructure_2024-09-19
branch
from
dc6f90a to
544c623
Compare
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
nreese
approved these changes
Sep 20, 2024
...c/dashboard_container/embeddable/create/controls/dashboard_control_group_integration.test.ts
Outdated
Show resolved
Hide resolved
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @Heenawter |
Heenawter
deleted the
embeddableRebuild_controls-folder-restructure_2024-09-19
branch
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 20, 2024
…der (elastic#193451) Final part of elastic#192005 ## Summary This PR marks the "final" major cleanup step for the control group refactor. This one is the simplest and does two things: 1. It removes the outer `react_controls` folder so that the new controls live directly under the `public` folder 2. It moves the `external_api` folder under the `control_group` folder Any files marked as "new" were not actually modified - this PR contains **no** logic changes. It **only** contains import changes due to the folder structure changing. ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) (cherry picked from commit 574eb26)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Sep 20, 2024
…0; top-level folder (#193451) (#193635) # Backport This will backport the following commits from `main` to `8.x`: - [[Embeddable Rebuild] [Controls] Remove `react_controls` top-level folder (#193451)](#193451) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Hannah Mudge","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-20T20:08:18Z","message":"[Embeddable Rebuild] [Controls] Remove `react_controls` top-level folder (#193451)\n\nFinal part of https://github.com/elastic/kibana/issues/192005\r\n\r\n## Summary\r\n\r\nThis PR marks the \"final\" major cleanup step for the control group\r\nrefactor. This one is the simplest and does two things:\r\n1. It removes the outer `react_controls` folder so that the new controls\r\nlive directly under the `public` folder\r\n2. It moves the `external_api` folder under the `control_group` folder\r\n\r\nAny files marked as \"new\" were not actually modified - this PR contains\r\n**no** logic changes. It **only** contains import changes due to the\r\nfolder structure changing.\r\n\r\n\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"574eb26cc70e36274384d82c36d9d6aa20ed7cc7","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Presentation","loe:small","release_note:skip","impact:medium","v9.0.0","backport:prev-minor","project:embeddableRebuild"],"title":"[Embeddable Rebuild] [Controls] Remove `react_controls` top-level folder","number":193451,"url":"https://github.com/elastic/kibana/pull/193451","mergeCommit":{"message":"[Embeddable Rebuild] [Controls] Remove `react_controls` top-level folder (#193451)\n\nFinal part of https://github.com/elastic/kibana/issues/192005\r\n\r\n## Summary\r\n\r\nThis PR marks the \"final\" major cleanup step for the control group\r\nrefactor. This one is the simplest and does two things:\r\n1. It removes the outer `react_controls` folder so that the new controls\r\nlive directly under the `public` folder\r\n2. It moves the `external_api` folder under the `control_group` folder\r\n\r\nAny files marked as \"new\" were not actually modified - this PR contains\r\n**no** logic changes. It **only** contains import changes due to the\r\nfolder structure changing.\r\n\r\n\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"574eb26cc70e36274384d82c36d9d6aa20ed7cc7"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193451","number":193451,"mergeCommit":{"message":"[Embeddable Rebuild] [Controls] Remove `react_controls` top-level folder (#193451)\n\nFinal part of https://github.com/elastic/kibana/issues/192005\r\n\r\n## Summary\r\n\r\nThis PR marks the \"final\" major cleanup step for the control group\r\nrefactor. This one is the simplest and does two things:\r\n1. It removes the outer `react_controls` folder so that the new controls\r\nlive directly under the `public` folder\r\n2. It moves the `external_api` folder under the `control_group` folder\r\n\r\nAny files marked as \"new\" were not actually modified - this PR contains\r\n**no** logic changes. It **only** contains import changes due to the\r\nfolder structure changing.\r\n\r\n\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"574eb26cc70e36274384d82c36d9d6aa20ed7cc7"}}]}] BACKPORT--> Co-authored-by: Hannah Mudge <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Final part of #192005
Summary
This PR marks the "final" major cleanup step for the control group refactor. This one is the simplest and does two things:
react_controlsfolder so that the new controls live directly under thepublicfolderexternal_apifolder under thecontrol_groupfolderAny files marked as "new" were not actually modified - this PR contains no logic changes. It only contains import changes due to the folder structure changing.
For maintainers