[Cloud Security] Cypress Test for Misconfiguration Preview and Table for Contextual Flyout #193125
Conversation
|
/ci |
|
/ci |
|
/ci |
animehart
added
backport:prev-minor
|
Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security) |
...security_solution_cypress/cypress/e2e/explore/hosts/misconfiguration_contextual_flyout.cy.ts
Outdated
Show resolved
Hide resolved
...security_solution_cypress/cypress/e2e/explore/hosts/misconfiguration_contextual_flyout.cy.ts
Outdated
Show resolved
Hide resolved
...security_solution_cypress/cypress/e2e/explore/hosts/misconfiguration_contextual_flyout.cy.ts
Outdated
Show resolved
Hide resolved
|
@animehart couple of asks:
|
animehart
changed the title
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
| @@ -0,0 +1,232 @@ | |||
| /* | |||
There was a problem hiding this comment.
Thanks for adding the test. Looks like it's interacting with alerts page and the flyout, shall we move it to x-pack/test/security_solution_cypress/cypress/e2e/investigations/alerts/expandable_flyout?
There was a problem hiding this comment.
ah kk
So I placed that test in the current folder because @machadoum suggested to put it here
would it be better if i move it to x-pack/test/security_solution_cypress/cypress/e2e/investigations/alerts/expandable_flyout instead ? @machadoum
There was a problem hiding this comment.
@animehart If the tested feature is only displayed inside the expandable flyout, placing the test where @angorayc suggested might make sense. But that is up to the @elastic/security-threat-hunting-investigations team to decide since they own the cypress/e2e/investigations folder. I strongly suggest you create a folder for your team (cloud_security_posture?) so you don't depend on other teams for code reviews.
There was a problem hiding this comment.
@machadoum
As discussed before, we were planning to add our own folder later, the reason being is because adding a specific folder for our team now will involve further steps to to make the new test to be ran on CI and because of this time constraint we think its better for us to put our test in existing folder for now
...security_solution_cypress/cypress/e2e/explore/hosts/misconfiguration_contextual_flyout.cy.ts
Outdated
Show resolved
Hide resolved
| }); | ||
|
|
||
| it('should display insight tabs and findings table upon clicking on misconfiguration accordion', () => { | ||
| cy.contains('Failed findings', { timeout: 3000 }); |
There was a problem hiding this comment.
🤔 Whenever I see a time-out in a test, it concerns me that we have a performance issue with the UI (sometimes the test runner).
Have we had to do the same in the Selenium tests for the Findings?
I would have expected with mock data that we should be showing the table in under 3 seconds.
| }); | ||
|
|
||
| it('should display insight tabs and findings table upon clicking on misconfiguration accordion', () => { | ||
| cy.get(CSP_INSIGHT_MISCONFIGURATION_TITLE).click(); |
There was a problem hiding this comment.
NIT: Wrap this issue into a task method.
| }); | ||
|
|
||
| it('should display insight tabs and findings table upon clicking on misconfiguration accordion', () => { | ||
| cy.get(CSP_INSIGHT_MISCONFIGURATION_TITLE).click(); |
There was a problem hiding this comment.
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#7178[✅] Cloud Security Posture - Cypress: 45/45 tests passed. |
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#7187[✅] Cloud Security Posture - Cypress: 45/45 tests passed. |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
|
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#7189[✅] Cloud Security Posture - Cypress: 45/45 tests passed. |
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#7190[✅] Cloud Security Posture - Cypress: 45/45 tests passed. |
animehart
added
backport:version
|
Starting backport for target branches: 8.16 https://github.com/elastic/kibana/actions/runs/11416138161 |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
… Table for Contextual Flyout (#193125) (#196974) # Backport This will backport the following commits from `main` to `8.16`: - [[Cloud Security] Cypress Test for Misconfiguration Preview and Table for Contextual Flyout (#193125)](#193125) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Rickyanto Ang","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-19T08:39:50Z","message":"[Cloud Security] Cypress Test for Misconfiguration Preview and Table for Contextual Flyout (#193125)\n\n## Summary\r\nThis PR is for Cypress test for the Misconfiguration Preview and Data\r\ntable\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"2de1f4a55805d4a6d4d3560e3025798e33db87b5","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Cloud Security","v8.16.0","backport:version"],"number":193125,"url":"https://github.com/elastic/kibana/pull/193125","mergeCommit":{"message":"[Cloud Security] Cypress Test for Misconfiguration Preview and Table for Contextual Flyout (#193125)\n\n## Summary\r\nThis PR is for Cypress test for the Misconfiguration Preview and Data\r\ntable\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"2de1f4a55805d4a6d4d3560e3025798e33db87b5"}},"sourceBranch":"main","suggestedTargetBranches":["8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193125","number":193125,"mergeCommit":{"message":"[Cloud Security] Cypress Test for Misconfiguration Preview and Table for Contextual Flyout (#193125)\n\n## Summary\r\nThis PR is for Cypress test for the Misconfiguration Preview and Data\r\ntable\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"2de1f4a55805d4a6d4d3560e3025798e33db87b5"}},{"branch":"8.16","label":"v8.16.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> --------- Co-authored-by: kibanamachine <[email protected]>
|
@animehart there's a version gap with this backport. Can you check if this should also be backported to 8.x/8.17? |
animehart
added
v8.17.0
backport:prev-minor
|
Starting backport for target branches: 8.16, 8.x https://github.com/elastic/kibana/actions/runs/11499566796 |
…for Contextual Flyout (elastic#193125) ## Summary This PR is for Cypress test for the Misconfiguration Preview and Data table --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit 2de1f4a)
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
…Table for Contextual Flyout (#193125) (#197631) # Backport This will backport the following commits from `main` to `8.x`: - [[Cloud Security] Cypress Test for Misconfiguration Preview and Table for Contextual Flyout (#193125)](#193125) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Rickyanto Ang","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-19T08:39:50Z","message":"[Cloud Security] Cypress Test for Misconfiguration Preview and Table for Contextual Flyout (#193125)\n\n## Summary\r\nThis PR is for Cypress test for the Misconfiguration Preview and Data\r\ntable\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"2de1f4a55805d4a6d4d3560e3025798e33db87b5","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Cloud Security","backport:prev-minor","v8.16.0","backport:version"],"title":"[Cloud Security] Cypress Test for Misconfiguration Preview and Table for Contextual Flyout ","number":193125,"url":"https://github.com/elastic/kibana/pull/193125","mergeCommit":{"message":"[Cloud Security] Cypress Test for Misconfiguration Preview and Table for Contextual Flyout (#193125)\n\n## Summary\r\nThis PR is for Cypress test for the Misconfiguration Preview and Data\r\ntable\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"2de1f4a55805d4a6d4d3560e3025798e33db87b5"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193125","number":193125,"mergeCommit":{"message":"[Cloud Security] Cypress Test for Misconfiguration Preview and Table for Contextual Flyout (#193125)\n\n## Summary\r\nThis PR is for Cypress test for the Misconfiguration Preview and Data\r\ntable\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"2de1f4a55805d4a6d4d3560e3025798e33db87b5"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/196974","number":196974,"state":"MERGED","mergeCommit":{"sha":"29333f8587a711562785cf98d32dc7f6d819bb28","message":"[8.16] [Cloud Security] Cypress Test for Misconfiguration Preview and Table for Contextual Flyout (#193125) (#196974)\n\n# Backport\r\n\r\nThis will backport the following commits from `main` to `8.16`:\r\n- [[Cloud Security] Cypress Test for Misconfiguration Preview and Table\r\nfor Contextual Flyout\r\n(#193125)](https://github.com/elastic/kibana/pull/193125)\r\n\r\n<!--- Backport version: 8.9.8 -->\r\n\r\n### Questions ?\r\nPlease refer to the [Backport tool\r\ndocumentation](https://github.com/sqren/backport)\r\n\r\n<!--BACKPORT [{\"author\":{\"name\":\"Rickyanto\r\nAng\",\"email\":\"[email protected]\"},\"sourceCommit\":{\"committedDate\":\"2024-10-19T08:39:50Z\",\"message\":\"[Cloud\r\nSecurity] Cypress Test for Misconfiguration Preview and Table for\r\nContextual Flyout (#193125)\\n\\n## Summary\\r\\nThis PR is for Cypress test\r\nfor the Misconfiguration Preview and\r\nData\\r\\ntable\\r\\n\\r\\n---------\\r\\n\\r\\nCo-authored-by: kibanamachine\r\n<[email protected]>\",\"sha\":\"2de1f4a55805d4a6d4d3560e3025798e33db87b5\",\"branchLabelMapping\":{\"^v9.0.0$\":\"main\",\"^v8.17.0$\":\"8.x\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"release_note:skip\",\"v9.0.0\",\"Team:Cloud\r\nSecurity\",\"v8.16.0\",\"backport:version\"],\"number\":193125,\"url\":\"https://github.com/elastic/kibana/pull/193125\",\"mergeCommit\":{\"message\":\"[Cloud\r\nSecurity] Cypress Test for Misconfiguration Preview and Table for\r\nContextual Flyout (#193125)\\n\\n## Summary\\r\\nThis PR is for Cypress test\r\nfor the Misconfiguration Preview and\r\nData\\r\\ntable\\r\\n\\r\\n---------\\r\\n\\r\\nCo-authored-by: kibanamachine\r\n<[email protected]>\",\"sha\":\"2de1f4a55805d4a6d4d3560e3025798e33db87b5\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[\"8.16\"],\"targetPullRequestStates\":[{\"branch\":\"main\",\"label\":\"v9.0.0\",\"labelRegex\":\"^v9.0.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/193125\",\"number\":193125,\"mergeCommit\":{\"message\":\"[Cloud\r\nSecurity] Cypress Test for Misconfiguration Preview and Table for\r\nContextual Flyout (#193125)\\n\\n## Summary\\r\\nThis PR is for Cypress test\r\nfor the Misconfiguration Preview and\r\nData\\r\\ntable\\r\\n\\r\\n---------\\r\\n\\r\\nCo-authored-by: kibanamachine\r\n<[email protected]>\",\"sha\":\"2de1f4a55805d4a6d4d3560e3025798e33db87b5\"}},{\"branch\":\"8.16\",\"label\":\"v8.16.0\",\"labelRegex\":\"^v(\\\\d+).(\\\\d+).\\\\d+$\",\"isSourceBranch\":false,\"state\":\"NOT_CREATED\"}]}]\r\nBACKPORT-->\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>"}}]}] BACKPORT--> Co-authored-by: Rickyanto Ang <[email protected]>
Summary
This PR is for Cypress test for the Misconfiguration Preview and Data table