Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ResponseOps] Add user-error tags to action logs #193066

Merged
merged 1 commit into from
Sep 17, 2024
Merged

[ResponseOps] Add user-error tags to action logs #193066

merged 1 commit into from
Sep 17, 2024
+3 −3

Conversation

doakalexi
Copy link
Contributor

@doakalexi doakalexi commented Sep 16, 2024 •
edited by kibanamachine
Loading

Resolves #192715

Summary

Adds user-error and framework-error tags to the action error logs

Checklist

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #38 / Alerting APIs Summary actions should schedule actions for summary of alerts on a custom interval
  • [job] [logs] FTR Configs #21 / Serverless Index Management APIs Inference endpoints "after all" hook for "can delete inference endpoint"
  • [job] [logs] FTR Configs #21 / Serverless Index Management APIs Inference endpoints create inference endpoint

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@doakalexi doakalexi changed the title Adding error source to the actions error logs [ResponseOps] Add user-error tags to action logs Sep 16, 2024
@doakalexi doakalexi added backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) release_note:skip Skip the PR/issue when compiling release notes v8.16.0 v9.0.0 labels Sep 16, 2024
@doakalexi doakalexi marked this pull request as ready for review September 17, 2024 15:39
@doakalexi doakalexi requested a review from a team as a code owner September 17, 2024 15:39
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

ymao1
ymao1 approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@ymao1 ymao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@doakalexi doakalexi merged commit e47eff1 into elastic:main Sep 17, 2024
29 checks passed
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 17, 2024
@doakalexi
[ResponseOps] Add user-error tags to action logs (elastic#193066)
40a5e57 
Resolves elastic#192715

## Summary

Adds user-error and framework-error tags to the action error logs

### Checklist

- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit e47eff1)
@kibanamachine kibanamachine mentioned this pull request Sep 17, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Sep 17, 2024
@kibanamachine @doakalexi
[8.x] [ResponseOps] Add user-error tags to action logs (#193066) (#19…
3c9beb0 
…3212)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[ResponseOps] Add user-error tags to action logs
(#193066)](#193066)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Alexi
Doak","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-17T17:31:11Z","message":"[ResponseOps]
Add user-error tags to action logs (#193066)\n\nResolves
https://github.com/elastic/kibana/issues/192715\r\n\r\n##
Summary\r\n\r\nAdds user-error and framework-error tags to the action
error logs\r\n\r\n\r\n### Checklist\r\n\r\n- [ ] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"e47eff12204885a2c280d07e42fb8a96fa61c778","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","v9.0.0","backport:prev-minor","v8.16.0"],"title":"[ResponseOps]
Add user-error tags to action
logs","number":193066,"url":"https://github.com/elastic/kibana/pull/193066","mergeCommit":{"message":"[ResponseOps]
Add user-error tags to action logs (#193066)\n\nResolves
https://github.com/elastic/kibana/issues/192715\r\n\r\n##
Summary\r\n\r\nAdds user-error and framework-error tags to the action
error logs\r\n\r\n\r\n### Checklist\r\n\r\n- [ ] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"e47eff12204885a2c280d07e42fb8a96fa61c778"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193066","number":193066,"mergeCommit":{"message":"[ResponseOps]
Add user-error tags to action logs (#193066)\n\nResolves
https://github.com/elastic/kibana/issues/192715\r\n\r\n##
Summary\r\n\r\nAdds user-error and framework-error tags to the action
error logs\r\n\r\n\r\n### Checklist\r\n\r\n- [ ] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"e47eff12204885a2c280d07e42fb8a96fa61c778"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Alexi Doak <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ymao1 ymao1 ymao1 approved these changes

@ersin-erdal ersin-erdal Awaiting requested review from ersin-erdal

Assignees
No one assigned
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.16.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add user-error tags to action logs
5 participants
@doakalexi @kibana-ci @elasticmachine @kibanamachine @ymao1