-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ES|QL] exclude inactive integration data stream suggestions #192953
[ES|QL] exclude inactive integration data stream suggestions #192953
Conversation
Pinging @elastic/kibana-esql (Team:ESQL) |
/ci |
@drewdaemon I know that the backport labels are confusing but backport:prev-major that you had set backports to 8.15 which the change from the fleet team is not applied. If we want to backport only in 8.16 the backport:prev-minor is the correct one. I changed it correctly |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
…#192953) ## Summary Close elastic#187247 https://github.com/user-attachments/assets/9f56d941-016a-442a-a2cb-b2240b280b54 Co-authored-by: Stratoula Kalafateli <[email protected]> (cherry picked from commit 462e437)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
…192953) (#192970) # Backport This will backport the following commits from `main` to `8.x`: - [[ES|QL] exclude inactive integration data stream suggestions (#192953)](#192953) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Drew Tate","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-16T08:24:55Z","message":"[ES|QL] exclude inactive integration data stream suggestions (#192953)\n\n## Summary\r\n\r\nClose https://github.com/elastic/kibana/issues/187247\r\n\r\n\r\nhttps://github.com/user-attachments/assets/9f56d941-016a-442a-a2cb-b2240b280b54\r\n\r\nCo-authored-by: Stratoula Kalafateli <[email protected]>","sha":"462e4378100e8d5233e7379f9244da5609b7dd2c","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","backport:prev-minor","Feature:ES|QL","Team:ESQL"],"title":"[ES|QL] exclude inactive integration data stream suggestions","number":192953,"url":"https://github.com/elastic/kibana/pull/192953","mergeCommit":{"message":"[ES|QL] exclude inactive integration data stream suggestions (#192953)\n\n## Summary\r\n\r\nClose https://github.com/elastic/kibana/issues/187247\r\n\r\n\r\nhttps://github.com/user-attachments/assets/9f56d941-016a-442a-a2cb-b2240b280b54\r\n\r\nCo-authored-by: Stratoula Kalafateli <[email protected]>","sha":"462e4378100e8d5233e7379f9244da5609b7dd2c"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/192953","number":192953,"mergeCommit":{"message":"[ES|QL] exclude inactive integration data stream suggestions (#192953)\n\n## Summary\r\n\r\nClose https://github.com/elastic/kibana/issues/187247\r\n\r\n\r\nhttps://github.com/user-attachments/assets/9f56d941-016a-442a-a2cb-b2240b280b54\r\n\r\nCo-authored-by: Stratoula Kalafateli <[email protected]>","sha":"462e4378100e8d5233e7379f9244da5609b7dd2c"}}]}] BACKPORT--> Co-authored-by: Drew Tate <[email protected]>
@stratoula my backport to 8.15 was intentional. I saw that the Fleet PR was also backported to 8.15: #192631 (comment). However, it looks like they closed their 8.15 backport so I agree that it doesn't make sense for us. |
yes this is my point, we should also check the backports and the PR labels before we add the backport labels to our PRs, here the backport didnt happen so we should not backport either (I understood why you did it, I just wanted to highlight that we need to be extra cautious with these PRs that depend on others ) |
…#192953) ## Summary Close elastic#187247 https://github.com/user-attachments/assets/9f56d941-016a-442a-a2cb-b2240b280b54 Co-authored-by: Stratoula Kalafateli <[email protected]>
Summary
Close #187247
Screen.Recording.2024-09-14.at.4.03.34.PM.mov