Add rowgroup, row and cell attributes to log stream components #192841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
ci:project-deploy-observability
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
gbamparop
added
release_note:skip
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
tonyghiani
reviewed
Sep 25, 2024
| <EuiButton data-test-subj="infraProgressCtaStreamLiveButton" onClick={onStreamStart} size="s"> | ||
| <FormattedMessage id="xpack.logsShared.logs.streamLive" defaultMessage="Stream live" /> | ||
| </EuiButton> | ||
| <div role="cell"> |
There was a problem hiding this comment.
Tip
EuiButton accepts the role attribute, do you think we can directly pass it there to not change the rendered markdown and avoid CSS side effects?
There was a problem hiding this comment.
I wanted to avoid changing the markup tbh but I followed the same suggestion with the other button displayed at the top of the log stream. I think the idea was to have a wrapper with a cell role, and then a button as a child element with a button role by default.
tonyghiani
approved these changes
Sep 25, 2024
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 26, 2024
…ic#192841) Closes elastic/observability-accessibility#123 Co-authored-by: Elastic Machine <[email protected]> (cherry picked from commit 01b9478)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Sep 26, 2024
…192841) (#194189) # Backport This will backport the following commits from `main` to `8.x`: - [Add rowgroup, row and cell attributes to log stream components (#192841)](#192841) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Giorgos Bamparopoulos","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-26T16:37:54Z","message":"Add rowgroup, row and cell attributes to log stream components (#192841)\n\nCloses https://github.com/elastic/observability-accessibility/issues/123\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"01b9478cf6c9f8f33efd9baf9979541d0e3eee2e","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability"],"title":"Add rowgroup, row and cell attributes to log stream components","number":192841,"url":"https://github.com/elastic/kibana/pull/192841","mergeCommit":{"message":"Add rowgroup, row and cell attributes to log stream components (#192841)\n\nCloses https://github.com/elastic/observability-accessibility/issues/123\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"01b9478cf6c9f8f33efd9baf9979541d0e3eee2e"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/192841","number":192841,"mergeCommit":{"message":"Add rowgroup, row and cell attributes to log stream components (#192841)\n\nCloses https://github.com/elastic/observability-accessibility/issues/123\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"01b9478cf6c9f8f33efd9baf9979541d0e3eee2e"}}]}] BACKPORT--> Co-authored-by: Giorgos Bamparopoulos <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the following roles:
rowgroupto thelogStreamwrapperrowandcellto the separator components (Showing entries from ...)rowandcellto the extra components (Extend time frame by...)Closes https://github.com/elastic/observability-accessibility/issues/123