Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RCA] Move charts closer, remove x-axis and labels #192550

Merged
merged 5 commits into from
Sep 11, 2024
Merged

[RCA] Move charts closer, remove x-axis and labels #192550

merged 5 commits into from
Sep 11, 2024

Conversation

benakansara
Copy link
Contributor

Resolves #192548

Screenshot 2024-09-11 at 10 54 03

@benakansara benakansara added release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-management Observability Management User Experience Team labels Sep 11, 2024
@benakansara benakansara self-assigned this Sep 11, 2024
@benakansara benakansara requested a review from a team as a code owner September 11, 2024 08:56
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Sep 11, 2024
@obltmachine
Copy link

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

kdelemme
kdelemme approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@kdelemme kdelemme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff, LGTM

...plugins/observability_solution/investigate_app/public/items/esql_item/register_esql_item.tsx
<lens.EmbeddableComponent
{...input}
style={{ height: 128 }}
overrides={{ axisX: { hide: true } }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe at some point, we might want to let the user toggle this option.

@benakansara benakansara enabled auto-merge (squash) September 11, 2024 15:08
@kibana-ci
Copy link
Collaborator

kibana-ci commented Sep 11, 2024 •
edited
Loading

💛 Build succeeded, but was flaky

  • Buildkite Build
  • Commit: 346490b
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-192550-346490bf7f91

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
investigateApp 380.3KB 380.5KB +162.0B
observability 463.5KB 463.5KB +21.0B
total +183.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @benakansara

@benakansara benakansara merged commit 233fe60 into elastic:main Sep 11, 2024
24 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Sep 11, 2024
@szaffarano szaffarano mentioned this pull request Sep 13, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdelemme kdelemme kdelemme approved these changes

Assignees

@benakansara benakansara

Labels
backport:skip This commit does not require backporting ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-management Observability Management User Experience Team v8.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RCA] Move charts closer, remove x-axis and labels
6 participants
@benakansara @elasticmachine @obltmachine @kibana-ci @kdelemme @kibanamachine