Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FTR] Fixup code owners check script #192453

Merged

Conversation

wayneseymour
Copy link
Member

@wayneseymour wayneseymour commented Sep 10, 2024

Summary

Ensure paths with empty owner annotations are included in the scripts output for missing code owners

Notes

With this change, the output of the script goes from this:

succ All test files have a code owner (checked 8243 test files in 6.78 s)

to this:

...
       - x-pack/test_serverless/functional/test_suites/security/cypress/tasks/navigation.ts
       - x-pack/test_serverless/functional/test_suites/security/index.feature_flags.ts
       - x-pack/test_serverless/functional/test_suites/security/index.ts
       - x-pack/test_serverless/functional/test_suites/security/screenshot_creation/index.ts
       - x-pack/test_serverless/kibana.jsonc
       - x-pack/test_serverless/tsconfig.json
ERROR Found 2594 test files without code owner (checked 8243 test files in 7.48 s)

Eventually, this script will be included in checks on ci, such that when it returns an error, the checks will fail and report back to a given PR owner.

@wayneseymour wayneseymour added Team:QA Team label for QA Team release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting labels Sep 10, 2024
@wayneseymour wayneseymour self-assigned this Sep 10, 2024
@wayneseymour wayneseymour requested a review from a team as a code owner September 10, 2024 10:19
@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-qa (Team:QA)

Copy link
Member

@pheyos pheyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @wayneseymour

@wayneseymour wayneseymour merged commit 3610dee into elastic:main Sep 10, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:QA Team label for QA Team v8.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants