-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Custom threshold] Improve the custom threshold rule request/response logging #192443
Conversation
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
@@ -69,9 +69,9 @@ export const checkMissingGroups = async ( | |||
]; | |||
}); | |||
|
|||
logger.trace(`Request: ${JSON.stringify({ searches })}`); | |||
logger.trace(() => `Request: ${JSON.stringify({ searches })}`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Created a ticket for improving logging msearch requests and responses: #192445
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
response ops changes LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Related to #187271
Summary
As mentioned in this PR, when logging a JSON stringified string for debugging or tracing, we need to wrap it in a function. This PR does this for the custom threshold rule and removes extra request/response logging, relying on alerting framework logging for that purpose.
Before, we were able to have a similar log using
plugins.observability
andplugins.alerting.observability.rules.custom_threshold
configs (as shown above), but now we only haveplugins.alerting.observability.rules.custom_threshold
which can be enabled by either of the following configs:Thanks @dgieselaar for bringing this to our attention!
How to test