Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix InvokeAIRaw bedrock subaction's schema #192015

Merged
merged 4 commits into from
Sep 3, 2024

Conversation

pgayvallet
Copy link
Contributor

Summary

Fix regression on InvokeAIRaw bedrock subaction introduced by #191434

@pgayvallet pgayvallet marked this pull request as ready for review September 3, 2024 16:36
@pgayvallet pgayvallet requested review from a team as code owners September 3, 2024 16:36
@@ -442,7 +442,7 @@ const formatBedrockBody = ({

interface FormattedBedRockMessage {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
interface FormattedBedRockMessage {
interface FormattedBedrockMessage {

This one too!

Copy link
Contributor

@stephmilovic stephmilovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please adjust those spots I mentioned with BedRockMessage =>BedrockMessage. Otherwise LGTM, thanks for the quick fix!

@stephmilovic stephmilovic added the release_note:skip Skip the PR/issue when compiling release notes label Sep 3, 2024
@pgayvallet pgayvallet enabled auto-merge (squash) September 3, 2024 17:53
@pgayvallet pgayvallet requested a review from a team as a code owner September 3, 2024 19:17
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Member

@pmuellr pmuellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ResponseOps changes are only the tests to reflect changes to the connectors parameters.

I assume nothings changed w/the ai connectors in that they are still only run "live" and not as alerting actions (or otherwise queued). Because if they are queued, we'd have some backwards compatibility issues to deal with.

Assuming that's not changed though ...

@pgayvallet pgayvallet merged commit 84c6815 into elastic:main Sep 3, 2024
19 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants