-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix InvokeAIRaw
bedrock subaction's schema
#192015
Fix InvokeAIRaw
bedrock subaction's schema
#192015
Conversation
@@ -442,7 +442,7 @@ const formatBedrockBody = ({ | |||
|
|||
interface FormattedBedRockMessage { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
interface FormattedBedRockMessage { | |
interface FormattedBedrockMessage { |
This one too!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please adjust those spots I mentioned with BedRockMessage
=>BedrockMessage
. Otherwise LGTM, thanks for the quick fix!
💚 Build Succeeded
Metrics [docs]
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ResponseOps changes are only the tests to reflect changes to the connectors parameters.
I assume nothings changed w/the ai connectors in that they are still only run "live" and not as alerting actions (or otherwise queued). Because if they are queued, we'd have some backwards compatibility issues to deal with.
Assuming that's not changed though ...
Summary
Fix regression on
InvokeAIRaw
bedrock subaction introduced by #191434