Monitoring Angular directives to use React components #19183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsullivan
added
WIP
This was referenced May 22, 2018
Merged
tsullivan
force-pushed
the
monitoring/directives-use-react-view
branch
2 times, most recently
from
2d9f799 to
12219ec
Compare
This was referenced May 24, 2018
tsullivan
force-pushed
the
monitoring/directives-use-react-view
branch
from
12219ec to
12d28f4
Compare
tsullivan
force-pushed
the
monitoring/directives-use-react-view
branch
from
12d28f4 to
854891a
Compare
|
@chrisronline this would be a good PR for you to review to see what's cooking with moving everything to React / EUI. This wipes out an Angular directive (Status Icon) that isn't used anymore because the container is entirely React now. |
💚 Build Succeeded |
tsullivan
added a commit
to tsullivan/kibana
that referenced
this pull request
Jul 19, 2018
* remove some webpack aliases for jest * remove status icon angular directive * fix some component import problems
tsullivan
added a commit
that referenced
this pull request
Jul 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #19052
This PR just has some hanging items left over after earlier work to implement Monitoring status bars in React instead of angular templates. This adds a unit test for status bar component, and removes the status icon angular directive