Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ES|QL] Add a helper to retrieve the metadata columns #191814

Merged
merged 3 commits into from
Aug 30, 2024

Conversation

stratoula
Copy link
Contributor

@stratoula stratoula commented Aug 30, 2024

Summary

Create a helper to retrieve the metadata columns (will come in handy for one discover project)

Checklist

@stratoula stratoula marked this pull request as ready for review August 30, 2024 10:42
@stratoula stratoula requested a review from a team as a code owner August 30, 2024 10:42
@stratoula stratoula added Feature:ES|QL ES|QL related features in Kibana Team:ESQL ES|QL related features in Kibana v8.16.0 labels Aug 30, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-esql (Team:ESQL)

@stratoula stratoula added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting labels Aug 30, 2024
@stratoula stratoula enabled auto-merge (squash) August 30, 2024 10:50
@stratoula
Copy link
Contributor Author

/ci

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #83 / InfraOps App Metrics UI Hosts View #With data #Single Host Flyout Tabs Overview Tab cpuUsage tile should show 48.3%

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/esql-utils 62 64 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
discover 771.2KB 771.2KB +2.0B
Unknown metric groups

API count

id before after diff
@kbn/esql-utils 66 68 +2

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stratoula stratoula merged commit cf0f3f6 into elastic:main Aug 30, 2024
25 checks passed
@davismcphee
Copy link
Contributor

Thanks @stratoula!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:ES|QL ES|QL related features in Kibana release_note:skip Skip the PR/issue when compiling release notes Team:ESQL ES|QL related features in Kibana v8.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants