-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(bump automation): bump ubi9 for ironbank #191660
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
- uses: docker/login-action@0d4c9c5ea7693da7b068278f7b52bda2a190a446 # v3.2.0 | ||
with: | ||
registry: ghcr.io | ||
username: ${{ github.actor }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be a bot instead? It seems that actor is not well defined, and would run in the context of an employee with their privlages, which doesn't seem to be ideal.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting. The official docs explained how to use this docker login with the GITHUB_TOKEN:
- https://github.com/docker/login-action#github-container-registry
- https://docs.github.com/en/packages/managing-github-packages-using-github-actions-workflows/publishing-and-installing-a-package-with-github-actions#upgrading-a-workflow-that-accesses-ghcrio
Maybe the issue with github.actor
is not the case for this specific use case. We have used this approach so far without any issues, for instance, see the below build for the same kind of code in a different GitHub repository:
I can see my username, but the following steps do what's expected (download the containers and so on ):
Likely, GitHub does something special with the login, and it's not honoured but the GITHUB_TOKEN
.
So far I think we are safe.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the links. I think you're correct that the actor
is not honored and the GITHUB_TOKEN
takes precedence. It's just a bit strange.
/ci |
💔 Build FailedFailed CI StepsHistoryTo update your PR or re-run it, just comment with: cc @v1v |
I'm afraid the name of the file is that |
You can add an exception to |
Thanks, see |
@Ikuni17, do you know how can I merge this PR? I don't think it requires to run the kibana-ci, changes are totally unrelated to what the CI does validate. Thanks 🙏 |
@v1v I think due to changes in |
Summary
Enable
updatecli
policies to bump the Ironbank versions automatically, then #182738 won't be manually created but when a new ubit9 version is released and available in the ironbank system.Those policies can be found at https://github.com/elastic/oblt-updatecli-policies/tree/main/updatecli/policies/ (NOTE: This is a private repository only accessible by Elastic employees)
Checklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers
How to test this PR locally
gh pr checkout 191660
$ GITHUB_TOKEN=$(gh auth token) updatecli compose diff --experimental
$ GITHUB_REPOSITORY=elastic/kibana \ GITHUB_ACTOR=v1v \ GITHUB_TOKEN=$(gh auth token) \ updatecli compose apply --experimental