-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Anomaly Detection: Adds a page to list supplied job configurations #191564
[ML] Anomaly Detection: Adds a page to list supplied job configurations #191564
Conversation
@szabosteve - pinging you for feedback on the copy used. 🙏 |
x-pack/plugins/ml/public/application/supplied_configurations/supplied_configurations.tsx
Outdated
Show resolved
Hide resolved
.../application/supplied_configurations/supplied_configurations_flyout/overview_tab_content.tsx
Outdated
Show resolved
Hide resolved
.../application/supplied_configurations/supplied_configurations_flyout/overview_tab_content.tsx
Outdated
Show resolved
Hide resolved
...l/public/application/routing/routes/supplied_configurations/supplied_configurations_view.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/ml/public/application/components/ml_page/side_nav.tsx
Outdated
Show resolved
Hide resolved
...l/public/application/routing/routes/supplied_configurations/supplied_configurations_view.tsx
Outdated
Show resolved
Hide resolved
.../application/supplied_configurations/supplied_configurations_flyout/overview_tab_content.tsx
Outdated
Show resolved
Hide resolved
...blic/application/supplied_configurations/supplied_configurations_flyout/jobs_tab_content.tsx
Show resolved
Hide resolved
.../application/supplied_configurations/supplied_configurations_flyout/overview_tab_content.tsx
Outdated
Show resolved
Hide resolved
...blic/application/supplied_configurations/supplied_configurations_flyout/data_views_table.tsx
Outdated
Show resolved
Hide resolved
.../application/supplied_configurations/supplied_configurations_flyout/overview_tab_content.tsx
Show resolved
Hide resolved
<p> | ||
<FormattedMessage | ||
id="xpack.ml.anomalyDetection.suppliedConfigurationsFlyout.unableToUseModuleHelpMessage" | ||
defaultMessage="These supplied configurations can be used in {appName}." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe something like These jobs can be created in the {appName} app.
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed offline, note that the Logs jobs can't be created in the Serverless oblt project, so we'll need to remove the text about using the jobs in the Logs app on serverless.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@peteharverson - for serverless security, the tags have been updated to only show compatible modules so there's no need to do anything on the browserside to check.
As for oblt - do those need to be shown if they can't be used at all? Should we just remove the 'observability' tag which will ensure they aren't shown in this view at all? cc @jgowdyelastic
For example, those won't show up as they are filtered out by tag in the modules endpoint.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed copy in oblt in b21695c
.../application/supplied_configurations/supplied_configurations_flyout/overview_tab_content.tsx
Show resolved
Hide resolved
...ic/application/supplied_configurations/supplied_configurations_flyout/kibana_tab_content.tsx
Outdated
Show resolved
Hide resolved
.../application/supplied_configurations/supplied_configurations_flyout/overview_tab_content.tsx
Outdated
Show resolved
Hide resolved
.../application/supplied_configurations/supplied_configurations_flyout/overview_tab_content.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/ml/public/application/supplied_configurations/supplied_configurations.tsx
Outdated
Show resolved
Hide resolved
.../application/supplied_configurations/supplied_configurations_flyout/overview_tab_content.tsx
Outdated
Show resolved
Hide resolved
.../application/supplied_configurations/supplied_configurations_flyout/overview_tab_content.tsx
Show resolved
Hide resolved
@peteharverson, @szabosteve - Thank you so much for taking a look! Would you be up for resolving the comments once you confirm the suggested update has been added? Would help reduce the noise. Thank you! 🙏 |
Good call! Updated in cdb1656 |
Gave this another test against cdb1656 (stateful, and serverless oblt). Overall looks good and resolved most of my previous comments. Only items left from my testing are:
|
@jgowdyelastic - all updates added in c81e7f6 |
x-pack/plugins/ml/public/application/supplied_configurations/supplied_configurations.tsx
Outdated
Show resolved
Hide resolved
.../application/supplied_configurations/supplied_configurations_flyout/overview_tab_content.tsx
Outdated
Show resolved
Hide resolved
.../application/supplied_configurations/supplied_configurations_flyout/overview_tab_content.tsx
Outdated
Show resolved
Hide resolved
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UI text LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test latest changes locally and on cloud, and LGTM
async getDashboardEditUrl(dashboardId: string) { | ||
async fetchDashboardsById(ids: string[]) { | ||
const findDashboardsService = await dashboardService.findDashboardsService(); | ||
const responses = await findDashboardsService.findByIds(ids); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These errors are actually not thrown from here - findByIds
has it's own error handling internally in src/plugins/dashboard/public/services/dashboard_content_management/lib/find_dashboards.ts
and returns the caught error in an object with a 'status' and 'error' property. The response is type FindDashboardsByIdResponse
- which is defined in that same file I shared. That's why here - we simply filter out the results with error status.
I think if we want to do something to remove the logged 404s, it will need to be in a separate PR and would need to chat with whoever maintains that service.
Good point - updated to make the style consistent in 7d8cbbd |
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Public APIs missing exports
Page load bundle
Unknown metric groupsasync chunk count
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Link to this view will be added to observable/stateful nav in this PR |
Summary
This PR adds a page in the UI for 'Supplied configurations'
Dependent on this fix to the endpoint schema going in first: #191633
NOTE: This item will be added to the side-nav of oblt serverless once this update is in: #190458 - replaced by #192050
Adds dedicated UI page for preconfigured job packages - subitem of the Anomaly Detection navigation:
When they can't be run in the ML UI:
When selected - flyout opens to reveal package assets:
Clicking the
Run data recognizer
button shows matching data views (if any) with link to job creation:Empty table when no matching dataviews are found:
Jobs tab of flyout:
kibana tab of flyout:
Checklist
Delete any items that are not applicable to this PR.